Fix various (minor) issues

.php-cs-fixer.dist.php

@@ -26,6 +26,10 @@
     )
     ->append([
         __DIR__.'/.php_cs.dist',
+        __DIR__.'/bin/console',
+        __DIR__.'/bin/doctrine_purge',
+        __DIR__.'/bin/eloquent_migrate',
+        __DIR__.'/bin/eloquent_rollback',
     ])
 ;
 

bin/console

@@ -23,32 +23,34 @@ use Symfony\Component\HttpKernel\KernelInterface;
 
 $serverArgs = &$_SERVER['argv'];
 $kernelInput = 'NakedKernel';
+
 foreach ($serverArgs as $index => $arg) {
     if ('-k' === $arg || '--kernel' === $arg) {
         $kernelInput = $serverArgs[$index + 1];
-        unset($serverArgs[$index]);
-        unset($serverArgs[$index + 1]);
+        unset($serverArgs[$index], $serverArgs[$index + 1]);
+
         break;
     }
 
-    if ('-k=' === substr($arg, 0, 3)) {
-        $kernelInput = substr($serverArgs[$index], 3);
+    if (str_starts_with($arg, '-k=')) {
+        $kernelInput = substr($arg, 3);
         unset($serverArgs[$index]);
         break;
     }
 
-    if ('--kernel=' === substr($arg, 0, 9)) {
-        $kernelInput = substr($serverArgs[$index], 9);
+    if (str_starts_with($arg, '--kernel=')) {
+        $kernelInput = substr($arg, 9);
         unset($serverArgs[$index]);
         break;
     }
 }
+
 $serverArgs = array_values($serverArgs);
 $kernelClass = 'Fidry\AliceDataFixtures\Bridge\Symfony\SymfonyApp\\'.$kernelInput;
 
 $input = new ArgvInput();
-$env = $input->getParameterOption(array('--env', '-e'), getenv('SYMFONY_ENV') ?: uniqid());
-$debug = getenv('SYMFONY_DEBUG') !== '0' && !$input->hasParameterOption(array('--no-debug', '')) && $env !== 'prod';
+$env = $input->getParameterOption(['--env', '-e'], getenv('SYMFONY_ENV') ?: bin2hex(random_bytes(6)));
+$debug = getenv('SYMFONY_DEBUG') !== '0' && !$input->hasParameterOption(['--no-debug', '']) && $env !== 'prod';
 
 if ($debug) {
     Debug::enable();

fixtures/Bridge/Eloquent/MigratorFactory.php

@@ -16,9 +16,11 @@
 use Fidry\AliceDataFixtures\Bridge\Eloquent\Migration\FakeMigrationRepository;
 use Illuminate\Database\Migrations\Migrator;
 use Illuminate\Filesystem\Filesystem;
+use JetBrains\PhpStorm\Pure;
 
 class MigratorFactory
 {
+    #[Pure]
     public static function create(): Migrator
     {
         return new Migrator(

fixtures/Bridge/Eloquent/Model/AnotherDummy.php

@@ -18,23 +18,14 @@
 
 class AnotherDummy extends Model
 {
-    /**
-     * @inheritdoc
-     */
     protected $table = 'another_dummies';
 
-    /**
-     * @inheritdoc
-     */
     protected $fillable = [
         'id',
         'address',
         'dummy',
     ];
 
-    /**
-     * @inheritdoc
-     */
     public $timestamps = false;
 
     public function dummy(): BelongsTo

fixtures/Bridge/Symfony/Entity/Group.php

@@ -15,6 +15,7 @@
 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
+use JetBrains\PhpStorm\Pure;
 
 class Group
 {
@@ -25,6 +26,7 @@ class Group
      */
     private Collection $users;
 
+    #[Pure]
     public function __construct()
     {
         $this->users = new ArrayCollection();

fixtures/Bridge/Symfony/Entity/User.php

@@ -15,6 +15,7 @@
 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Collections\Collection;
+use JetBrains\PhpStorm\Pure;
 
 class User
 {
@@ -25,6 +26,7 @@ class User
      */
     private Collection $groups;
 
+    #[Pure]
     public function __construct()
     {
         $this->groups = new ArrayCollection();

fixtures/Bridge/Symfony/SymfonyApp/Bundle/DoctrineBundle.php

@@ -18,7 +18,7 @@
 
 class DoctrineBundle extends Bundle
 {
-    public function build(ContainerBuilder $container)
+    public function build(ContainerBuilder $container): void
     {
         parent::build($container);
 

fixtures/Bridge/Symfony/SymfonyApp/Bundle/DoctrineConnectionlessPass.php

@@ -19,10 +19,7 @@
 
 class DoctrineConnectionlessPass implements CompilerPassInterface
 {
-    /**
-     * @inheritdoc
-     */
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         try {
             $proxyCacheWarmerDefinition = $container->findDefinition('doctrine.orm.proxy_cache_warmer');

fixtures/Bridge/Symfony/SymfonyApp/InvalidKernel.php

@@ -14,10 +14,12 @@
 namespace Fidry\AliceDataFixtures\Bridge\Symfony\SymfonyApp;
 
 use Fidry\AliceDataFixtures\Bridge\Symfony\FidryAliceDataFixturesBundle;
+use JetBrains\PhpStorm\Pure;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 
 class InvalidKernel extends IsolatedKernel
 {
+    #[Pure]
     public function registerBundles(): array
     {
         return [

fixtures/Bridge/Symfony/SymfonyApp/IsolatedKernel.php

@@ -13,6 +13,8 @@
 
 namespace Fidry\AliceDataFixtures\Bridge\Symfony\SymfonyApp;
 
+use function bin2hex;
+use function random_bytes;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;
@@ -27,24 +29,24 @@ abstract class IsolatedKernel extends Kernel
      */
     public static function create()
     {
-        return new static(uniqid(), true);
+        return new static(bin2hex(random_bytes(6)), true);
     }
 
     public function build(ContainerBuilder $container): void
     {
         $container->addCompilerPass(
             new class() implements CompilerPassInterface {
-                public function process(ContainerBuilder $container)
+                public function process(ContainerBuilder $container): void
                 {
                     foreach ($container->getDefinitions() as $id => $definition) {
-                        if (strpos($id, 'fidry_alice_data_fixtures') !== 0) {
+                        if (!str_starts_with($id, 'fidry_alice_data_fixtures')) {
                             continue;
                         }
 
                         $definition->setPublic(true);
                     }
                     foreach ($container->getAliases() as $id => $definition) {
-                        if (strpos($id, 'fidry_alice_data_fixtures') !== 0) {
+                        if (!str_starts_with($id, 'fidry_alice_data_fixtures')) {
                             continue;
                         }
 

fixtures/Bridge/Symfony/SymfonyApp/NakedKernel.php

@@ -14,11 +14,13 @@
 namespace Fidry\AliceDataFixtures\Bridge\Symfony\SymfonyApp;
 
 use Fidry\AliceDataFixtures\Bridge\Symfony\FidryAliceDataFixturesBundle;
+use JetBrains\PhpStorm\Pure;
 use Nelmio\Alice\Bridge\Symfony\NelmioAliceBundle;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 
 class NakedKernel extends IsolatedKernel
 {
+    #[Pure]
     public function registerBundles(): array
     {
         return [

src/Bridge/Symfony/DependencyInjection/Compiler/RegisterTagServicesPass.php

@@ -13,6 +13,7 @@
 
 namespace Fidry\AliceDataFixtures\Bridge\Symfony\DependencyInjection\Compiler;
 
+use JetBrains\PhpStorm\Pure;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
@@ -25,6 +26,7 @@ final class RegisterTagServicesPass implements CompilerPassInterface
     private string $tagName;
     private TaggedDefinitionsLocator $taggedDefinitionsLocator;
 
+    #[Pure]
     public function __construct(string $registry, string $tagName)
     {
         $this->registry = $registry;

src/Bridge/Symfony/FidryAliceDataFixturesBundle.php

@@ -20,9 +20,6 @@
 
 final class FidryAliceDataFixturesBundle extends Bundle
 {
-    /**
-     * @inheritdoc
-     */
     public function build(ContainerBuilder $container): void
     {
         parent::build($container);

src/Exception/MaxPassReachedException.php

@@ -15,6 +15,7 @@
 
 use Fidry\AliceDataFixtures\Loader\ErrorTracker;
 use Fidry\AliceDataFixtures\Loader\FileTracker;
+use JetBrains\PhpStorm\Pure;
 use Nelmio\Alice\Throwable\LoadingThrowable;
 use RuntimeException;
 use Throwable;
@@ -29,6 +30,7 @@ class MaxPassReachedException extends RuntimeException implements LoadingThrowab
      */
     private array $stack = [];
 
+    #[Pure]
     public function __construct($message, $code = 0, Throwable $previous = null, ErrorTracker $errorTracker = null)
     {
         parent::__construct($message, $code, $previous);

src/Loader/FileResolverLoader.php

@@ -18,6 +18,7 @@
 use Fidry\AliceDataFixtures\Persistence\PersisterAwareInterface;
 use Fidry\AliceDataFixtures\Persistence\PersisterInterface;
 use Fidry\AliceDataFixtures\Persistence\PurgeMode;
+use JetBrains\PhpStorm\Pure;
 use Nelmio\Alice\IsAServiceTrait;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
@@ -35,6 +36,7 @@
     private FileResolverInterface $fileResolver;
     private LoggerInterface $logger;
 
+    #[Pure]
     public function __construct(
         LoaderInterface $decoratedLoader,
         FileResolverInterface $fileResolver,

src/Loader/PersisterLoader.php

@@ -18,6 +18,7 @@
 use Fidry\AliceDataFixtures\Persistence\PersisterInterface;
 use Fidry\AliceDataFixtures\Persistence\PurgeMode;
 use Fidry\AliceDataFixtures\ProcessorInterface;
+use JetBrains\PhpStorm\Pure;
 use Nelmio\Alice\IsAServiceTrait;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
@@ -42,6 +43,7 @@
     /**
      * @param ProcessorInterface[] $processors
      */
+    #[Pure]
     public function __construct(
         LoaderInterface $decoratedLoader,
         PersisterInterface $persister,

src/Loader/SimpleLoader.php

@@ -15,6 +15,7 @@
 
 use Fidry\AliceDataFixtures\LoaderInterface;
 use Fidry\AliceDataFixtures\Persistence\PurgeMode;
+use JetBrains\PhpStorm\Pure;
 use Nelmio\Alice\FilesLoaderInterface;
 use Nelmio\Alice\IsAServiceTrait;
 use Psr\Log\LoggerInterface;
@@ -35,6 +36,7 @@
     private FilesLoaderInterface $filesLoader;
     private LoggerInterface $logger;
 
+    #[Pure]
     public function __construct(FilesLoaderInterface $fileLoader, LoggerInterface $logger = null)
     {
         $this->filesLoader = $fileLoader;

tests/Bridge/Doctrine/Persister/ObjectManagerPersisterTest.php

@@ -53,12 +53,12 @@ public function tearDown(): void
 
     public function testIsAPersister(): void
     {
-        $this->assertTrue(is_a(ObjectManagerPersister::class, PersisterInterface::class, true));
+        self::assertTrue(is_a(ObjectManagerPersister::class, PersisterInterface::class, true));
     }
 
     public function testIsNotClonable(): void
     {
-        $this->assertFalse((new ReflectionClass(ObjectManagerPersister::class))->isCloneable());
+        self::assertFalse((new ReflectionClass(ObjectManagerPersister::class))->isCloneable());
     }
 
     /**
@@ -75,10 +75,10 @@ public function testCanPersistAnEntity($entity, bool $exact = false): void
 
         $result = $this->entityManager->getRepository(get_class($entity))->findAll();
 
-        $this->assertEquals(1, count($result));
+        self::assertCount(1, $result);
 
         if ($exact) {
-            $this->assertEquals($originalEntity, $result[0]);
+            self::assertEquals($originalEntity, $result[0]);
         }
     }
 
@@ -98,12 +98,12 @@ public function testCanPersistAnEntityWithRelationsAndExplicitIds(): void
         $this->entityManager->clear();
 
         $result = $this->entityManager->getRepository(DummyWithIdentifier::class)->findOneBy(['id' => 100]);
-        $this->assertInstanceOf(DummyWithIdentifier::class, $result);
-        $this->assertEquals($result->id, $dummy->id);
+        self::assertInstanceOf(DummyWithIdentifier::class, $result);
+        self::assertEquals($result->id, $dummy->id);
 
         $result = $this->entityManager->getRepository(DummyWithRelation::class)->findOneBy(['id' => 200]);
-        $this->assertInstanceOf(DummyWithRelation::class, $result);
-        $this->assertEquals($result->id, $dummyWithRelation->id);
+        self::assertInstanceOf(DummyWithRelation::class, $result);
+        self::assertEquals($result->id, $dummyWithRelation->id);
     }
 
     public function testCanPersistMultipleEntitiesWithExplicitIdentifierSet(): void
@@ -118,7 +118,7 @@ public function testCanPersistMultipleEntitiesWithExplicitIdentifierSet(): void
 
         $classMetadata = $this->entityManager->getClassMetadata(DummyWithIdentifier::class);
 
-        $this->assertEquals(
+        self::assertEquals(
             IdGenerator::class,
             get_class($classMetadata->idGenerator),
             'ID generator should be changed.'
@@ -128,14 +128,14 @@ public function testCanPersistMultipleEntitiesWithExplicitIdentifierSet(): void
 
         $classMetadata = $this->entityManager->getClassMetadata(DummyWithIdentifier::class);
 
-        $this->assertNotEquals(
+        self::assertNotEquals(
             IdGenerator::class,
             get_class($classMetadata->idGenerator),
             'ID generator should be restored after flush.'
         );
 
         $entity = $this->entityManager->getRepository(DummyWithIdentifier::class)->find(200);
-        $this->assertInstanceOf(DummyWithIdentifier::class, $entity);
+        self::assertInstanceOf(DummyWithIdentifier::class, $entity);
     }
 
     public function testCanPersistEntitiesWithoutExplicitIdentifierSetEvenWhenExistingEntitiesHaveOne(): void
@@ -171,10 +171,10 @@ public function testCanPersistEntitiesWithoutExplicitIdentifierSetEvenWhenExisti
         $this->persister->flush();
 
         $entity = $this->entityManager->getRepository(Dummy::class)->find($dummy1->id);
-        $this->assertInstanceOf(Dummy::class, $entity);
+        self::assertInstanceOf(Dummy::class, $entity);
 
         $entity = $this->entityManager->getRepository(Dummy::class)->find($dummy2->id);
-        $this->assertInstanceOf(Dummy::class, $entity);
+        self::assertInstanceOf(Dummy::class, $entity);
     }
 
     public function testPersistingMultipleEntitiesWithAndWithoutExplicitIdentifierSetWillNotThrowORMException(): void
@@ -210,7 +210,7 @@ public function testDoesNotPersistEmbeddables($dummy): void
         $this->persister->persist($dummy);
         $this->persister->flush();
 
-        $this->assertTrue(true, 'Everything is fine.');
+        self::assertTrue(true, 'Everything is fine.');
     }
 
     public static function provideEntities(): iterable
@@ -238,7 +238,7 @@ public static function provideEntities(): iterable
         ];
 
         yield 'entity with explicit ID' => [
-            (function () {
+            (static function () {
                 $dummy = new DummyWithIdentifier();
                 $dummy->id = 300;