Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import API types from planx-core for key data structures (FlowGraph, Node, Breadcrumbs etc) #2405

Open
DafyddLlyr opened this issue Nov 8, 2023 · 0 comments
Open

Import API types from planx-core for key data structures (FlowGraph, Node, Breadcrumbs etc) #2405

DafyddLlyr opened this issue Nov 8, 2023 · 0 comments
Labels
future enhancement Something to think about for the future, not a current priority

Comments

@DafyddLlyr
Copy link
Contributor

DafyddLlyr commented Nov 8, 2023 •
edited
Loading

Currently, API types are defined that don't quite match their stricter planx-core counterparts (see comment here #2375 (comment)).

Doing this would allow us to work more safely, and standardise how we handle these data structures.

Where possible, I'm adding the JSDoc @deprecated to types I know need to be tidied up.
@DafyddLlyr DafyddLlyr mentioned this issue Nov 8, 2023
Merged
@DafyddLlyr DafyddLlyr added the future enhancement Something to think about for the future, not a current priority label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future enhancement Something to think about for the future, not a current priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DafyddLlyr