-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow import through WORKSPACE #75
Comments
I think you can safely use bzlmod and WORKSPACE configurations (we did this when we cut over from WORKSPACE to bzlmod). It'd be worth a shot before you write it off. The rules_python maintainers are currently working on adding uv directly to rules_python, too. |
I've tried already. TensorFlow is very bazelmod unfriendly at the moment. Your dependencies will try to catch rules_cc transitively and a few other dependencies, and TF won't like it as it tries to patch them extensively... Here is what I ended up with. Taking rules_python plan to integrate, and they support WORKSPACE file, it if fine for now.
The only catch here is the private "@rules_uv//uv/private:uv.lock.json". Nevertheless, due to other less friendly dependencies, I am anyway forced to disable visibility check, so that I am fine as well. For anyone deciding to use the code above, copy the context of the lock file and point multitool to it instead. |
Ah, gotcha. Thanks for sharing a detailed workaround. |
Any chance you can allow import through WORKSPACE file?
Motivation: we depend on TensorFlow repository and using bazelmod is practically impossible until TensorFlow has updated first. They claim to be working on it, but it won't come in the foreseeable future, I guess.
rules_uv seems the most convenient way of generating requirement files for linux/aarch64, linux/amd64 and darwin/arm64 to be further used by rules_python. Sadly, they lack that functionality themselves.
The text was updated successfully, but these errors were encountered: