"Point" terminology

[dave1010]

An instance of the Point class has an origin and a destination coordinate. This seems like poor naming, as in most GIS implementations (and semantically) a point has exactly 1 coordinate.

Having a quick Google around, either MultiPoint or Line would make more sense, although these are generally not limited to 2 coordinates.

Maybe I'm viewing the class wrongly and it shouldn't be thought of a value object at all but a coordinate service / calculator. In that case perhaps Point should be in a different namespace that implies it's a tool rather than a value object, which is what Convert does.

Feel free to close as wontfix, as I guess "geotools" implies that this is a collection of tools, as opposed to a component to drop into the business domain.

[toin0u]

Hi @dave1010
You are 100% right and I also tought about that.. But I do not have a better name :) Do you have any suggestion maybe ?

[gabrielbull]

👍 for renaming to Line. It was confusing for me as well, took me time to figure out point was actually a line.

[toin0u]

I'm ok with Line :)

[codisart]

Hi sorry to intrude into the conversation but shouldn't the name of this class be Vertex ?

[toin0u]

@codisart I think your proposition sounds legit - it might be the best actually :)

[toin0u]

Fixed by #68 - Thanks @codisart !

[remi-san]

Hey,

I think there's been a misunderstanding there. What you described is an Edge, not a Vertex.

An edge is the line segment joining 2 vertices. Vertices are just a point, not a line.

So, it's going to be a new BC break, but I think that we should rename it once more.

[codisart]

Fudge, I think you right.

I thought vertex was the translation needed.
But, I just checked and in fact it is vector which is used to describe a segment with a direction.

(I'm french and vertex is so near the french word "vecteur" that I did not check the right meaning of the word, I am so sorry.)

[remi-san]

Here's my proposition to fix it: PR #87