-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Point" terminology #39
Comments
Hi @dave1010 |
👍 for renaming to |
I'm ok with |
Hi sorry to intrude into the conversation but shouldn't the name of this class be |
@codisart I think your proposition sounds legit - it might be the best actually :) |
Hey, I think there's been a misunderstanding there. What you described is an Edge, not a Vertex. An edge is the line segment joining 2 vertices. Vertices are just a point, not a line. So, it's going to be a new BC break, but I think that we should rename it once more. |
Fudge, I think you right. I thought vertex was the translation needed. (I'm french and vertex is so near the french word "vecteur" that I did not check the right meaning of the word, I am so sorry.) |
Here's my proposition to fix it: PR #87 |
An instance of the
Point
class has an origin and a destination coordinate. This seems like poor naming, as in most GIS implementations (and semantically) a point has exactly 1 coordinate.Having a quick Google around, either MultiPoint or Line would make more sense, although these are generally not limited to 2 coordinates.
Maybe I'm viewing the class wrongly and it shouldn't be thought of a value object at all but a coordinate service / calculator. In that case perhaps
Point
should be in a different namespace that implies it's a tool rather than a value object, which is whatConvert
does.Feel free to close as wontfix, as I guess "geotools" implies that this is a collection of tools, as opposed to a component to drop into the business domain.
The text was updated successfully, but these errors were encountered: