Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft of slide templates #10

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Conversation

aholtzman
Copy link
Collaborator

Related Issue

resolves issue #6 when complete

Summary of Changes

added 4 templates and modified another to get started.

@netlify
Copy link

netlify bot commented Jul 25, 2021

✔️ Deploy Preview for awesome-bhaskara-b7d76c ready!

🔨 Explore the source changes: 28fa3fb

🔍 Inspect the deploy log: https://app.netlify.com/sites/awesome-bhaskara-b7d76c/deploys/61018d084e0c94000885f5ff

😎 Browse the preview: https://deploy-preview-10--awesome-bhaskara-b7d76c.netlify.app

@thescientist13
Copy link
Owner

Awesome, thank you for getting this up!

Did a quick scan of the deploy preview and looks nice and clean! Will go through it a bit more a little later on today. 👀

@thescientist13 thescientist13 self-assigned this Jul 26, 2021
@thescientist13 thescientist13 added the enhancement New feature or request label Jul 26, 2021
@aholtzman
Copy link
Collaborator Author

It is meant as a starting place to have sufficient usable slide templates for your presentation. Anything else you want added or changed I am happy to work on.

@thescientist13 thescientist13 linked an issue Jul 27, 2021 that may be closed by this pull request
12 tasks
Copy link
Owner

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! 🏆

I had an idea and was curious on your thoughts as the typography was feeling a bit "blocky" to me. I bumped the font-weight for the h1 selector in main.css and I think it helped break things up a bit. I also bumped up the font-size in the title template to compensate.

Screen Shot 2021-07-27 at 12 30 05 PM
Screen Shot 2021-07-27 at 12 30 15 PM

@aholtzman
Copy link
Collaborator Author

Those are positive changes in my opinion.

email@example.com

![kitten](https://chuckanddons.com/media/wysiwyg/kitten_blog.jpg)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@thescientist13 thescientist13 marked this pull request as ready for review July 30, 2021 20:54
Copy link
Owner

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aholtzman , this is super helpful! 🙏 😊

I'm going to merge what's here so far, and keep the issue open for further contributions and opportunities. 🍻

@thescientist13 thescientist13 merged commit 03238d6 into master Jul 30, 2021
@thescientist13 thescientist13 deleted the task/update-slide-templates branch July 30, 2021 20:55
@thescientist13 thescientist13 mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default theming and styles for baseline presentation slides
2 participants