Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712 signer - add primaryType #212

Closed
r-czajkowski opened this issue Feb 1, 2024 · 0 comments
Closed

EIP-712 signer - add primaryType #212

r-czajkowski opened this issue Feb 1, 2024 · 0 comments
Labels
🔌 sdk TypeScript SDK Library

Comments

@r-czajkowski
Copy link
Contributor

r-czajkowski commented Feb 1, 2024 •
edited
Loading

EIP-712 defines also primaryType property. We should follow the standard more closely rather than ethers API.

Originally posted by @nkuba in #106 (comment)
@r-czajkowski r-czajkowski added the 🔌 sdk TypeScript SDK Library label Feb 1, 2024
@nkuba nkuba closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔌 sdk TypeScript SDK Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkuba @r-czajkowski