diff --git a/src/configuration/injection/containers/database.ts b/src/configuration/injection/containers/database.ts index 6584fc6..84052ef 100644 --- a/src/configuration/injection/containers/database.ts +++ b/src/configuration/injection/containers/database.ts @@ -11,7 +11,7 @@ const useAppDataSources = (): void => { const AppDataSource = new DataSource({ type: "postgres", synchronize: true, - logging: true, + logging: false, entities: ['src/driven/repositories/typeorm/entities/*.{ts,js}'], subscribers: [], migrations: ['src/driven/repositories/typeorm/migrations/*.{ts,js}'], diff --git a/src/core/domain/common/interfaces/transactionManager.ts b/src/core/domain/common/interfaces/transactionManager.ts index d72650c..cc03efc 100644 --- a/src/core/domain/common/interfaces/transactionManager.ts +++ b/src/core/domain/common/interfaces/transactionManager.ts @@ -1,5 +1,3 @@ -import TransactionInterface from './transaction'; - /** * Interface to manage commits and rollbacks within the system's core. * @@ -11,12 +9,6 @@ export default interface TransactionManagerInterface { */ startTransaction(): Promise; - /** - * Creates and returns a new transaction - * that can be used to commit without the need of the method startTransaction(). - */ - newTransaction(): TransactionInterface; - /** * Commits a change of state in the system. */ diff --git a/src/driven/repositories/inMemory/common/transactions/manager.ts b/src/driven/repositories/inMemory/common/transactions/manager.ts index 100bcff..6c49fc9 100644 --- a/src/driven/repositories/inMemory/common/transactions/manager.ts +++ b/src/driven/repositories/inMemory/common/transactions/manager.ts @@ -12,7 +12,8 @@ export default class InMemoryTransactionManager { } /** - * Returns a new in memory transaction. + * Creates and returns a new transaction + * that can be used to commit without the need of the method startTransaction(). */ newTransaction(): InMemoryTransaction { return new InMemoryTransaction(this.unitOfWork); diff --git a/tests/unit/car/query/retrieveCarsPlanning/retrieveCarsPlanning.test.ts b/tests/unit/car/query/retrieveCarsPlanning/retrieveCarsPlanning.test.ts index 6d92416..a6bc428 100644 --- a/tests/unit/car/query/retrieveCarsPlanning/retrieveCarsPlanning.test.ts +++ b/tests/unit/car/query/retrieveCarsPlanning/retrieveCarsPlanning.test.ts @@ -24,6 +24,7 @@ import PermissionsDenyStubGateway from "tests/common/stubs/gateways/permissions/ import {buildExpectedCarsPlanning} from "tests/unit/car/query/retrieveCarsPlanning/beforeEach"; import {buildCarTestCases} from "tests/unit/car/query/retrieveCarsPlanning/each"; import UserPermissionsProfile from "src/core/useCases/common/permissions/types/userPermissionsProfile"; +import InMemoryTransactionManager from "src/driven/repositories/inMemory/common/transactions/manager"; describe.each([ { @@ -324,7 +325,7 @@ describe.each([ beforeEach(async () => { useInMemoryRepositories(); - const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface"); + const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface"); const transaction: TransactionInterface = transactionManager.newTransaction(); const unitOfWork: UnitOfWork = container.resolve("UnitOfWork"); await populateCarModel({ @@ -494,7 +495,7 @@ describe.each([ beforeEach(async () => { useInMemoryRepositories(); - const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface"); + const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface"); const transaction: TransactionInterface = transactionManager.newTransaction(); const unitOfWork: UnitOfWork = container.resolve("UnitOfWork"); await populateCarModel({ diff --git a/tests/unit/carRental/command/rentACar.test.ts b/tests/unit/carRental/command/rentACar.test.ts index 5198ff5..aba963f 100644 --- a/tests/unit/carRental/command/rentACar.test.ts +++ b/tests/unit/carRental/command/rentACar.test.ts @@ -18,6 +18,7 @@ import InMemoryCarRentalReadRepository from 'src/driven/repositories/inMemory/ca import TransactionInterface from 'src/core/domain/common/interfaces/transaction'; import TransactionManagerInterface from 'src/core/domain/common/interfaces/transactionManager'; import UnavailableCarError from 'src/core/domain/car/errors/unavailable'; +import InMemoryTransactionManager from "src/driven/repositories/inMemory/common/transactions/manager"; describe.each([ { @@ -129,7 +130,7 @@ describe.each([ beforeEach(async () => { useInMemoryRepositories(); - const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface"); + const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface"); const transaction: TransactionInterface = transactionManager.newTransaction(); await populateCarsAndCarRentalsFromTestCase(testCase.cars); await populateAvailableCarFromTestCase(testCase.availableCar as CarTestCaseEntry); @@ -215,7 +216,7 @@ describe.each([ beforeEach(async () => { useInMemoryRepositories(); - const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface"); + const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface"); const transaction: TransactionInterface = transactionManager.newTransaction(); await populateAvailableCarFromTestCase(testCase.availableCar as CarTestCaseEntry); await transaction.commit(); diff --git a/tests/unit/carRental/query/retrieveACarRental.test.ts b/tests/unit/carRental/query/retrieveACarRental.test.ts index 7f0c495..d78bc52 100644 --- a/tests/unit/carRental/query/retrieveACarRental.test.ts +++ b/tests/unit/carRental/query/retrieveACarRental.test.ts @@ -13,6 +13,7 @@ import RetrieveACarRentalQuery from 'src/core/useCases/carRental/query/retrieveA import {populateCarModel, populateCarRental} from '../../utils/populate'; import UnitOfWork from 'src/driven/repositories/inMemory/common/unitOfWork'; import InMemoryCarRentalReadRepository from 'src/driven/repositories/inMemory/carRental/read'; +import InMemoryTransactionManager from "src/driven/repositories/inMemory/common/transactions/manager"; describe.each([ { @@ -76,7 +77,7 @@ describe.each([ beforeEach(async () => { useInMemoryRepositories(); const unitOfWork: UnitOfWork = container.resolve("UnitOfWork"); - const transactionManager: TransactionManagerInterface = container.resolve("TransactionManagerInterface"); + const transactionManager: InMemoryTransactionManager = container.resolve("TransactionManagerInterface"); const transaction: TransactionInterface = transactionManager.newTransaction(); const totalPrice = convertToNumericPrice(testCase.carRental.totalPrice); await populateCarRental({