Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puzzle.generateSeededScramble() should use a well defined PRNG #16

Open
jfly opened this issue Dec 18, 2013 · 1 comment
Open

Puzzle.generateSeededScramble() should use a well defined PRNG #16

jfly opened this issue Dec 18, 2013 · 1 comment

Comments

@jfly
Copy link
Contributor

jfly commented Dec 18, 2013

Right now, we use SecureRandom, which is implemented differently on different platforms. For WCA scrambles, that's fine, because we assume that each of these different implementations is cryptographically secure. However, for seeded scrambles (good for 2 people racing), we want the scrambles we generate to always been the same, regardless of platform. Perhaps we should add in a MersenneTwister (Yarrow? Fortuna?) implementation, specifically for seeded scrambles?

@gregorbg
Copy link
Member

gregorbg commented Jan 4, 2020

Do we even need seeded scrambles at all anymore?

More recently, they seem to have caused more harm than good (internal discussion about duplicate scrambles for Chinese competitions) and we do not need them for the WCA canon anyways.

@gregorbg gregorbg transferred this issue from thewca/tnoodle Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants