Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename *MIN_SCRAMBLE_LENGTH variables and check that they actually work #22

Open
jfly opened this issue Jan 8, 2014 · 4 comments
Open

Comments

@jfly
Copy link
Contributor

jfly commented Jan 8, 2014

See thewca/tnoodle#156 (comment) for renaming the variables, and thewca/tnoodle#156 (comment) for checking that pyraminx and 222 are always solvable in exactly God's number turns.

@chenshuang, do you think you can take this issue on when you've got some free time? There's no immediate rush here, but it's definitely something that should be done eventually.

@cs0x7f
Copy link
Contributor

cs0x7f commented Jan 8, 2014

OK. I'll check the assumption in about 2 weeks. BTW, the solution of pyraminx does not include tips, which means that the length might larger than "MIN_SCRAMBLE_LENGTH" or "EXACT_SCRAMBLE_LENGTH".

@lgarron
Copy link
Member

lgarron commented Jan 8, 2014

Wait, then how do we filter Pyraminx?

»Lucas Garron

On Wed, Jan 8, 2014 at 1:24 AM, Chen Shuang notifications@github.comwrote:

OK. I'll check the assumption in about 2 weeks. BTW, the solution of
pyraminx does not include tips, which means that the length might larger
than "MIN_SCRAMBLE_LENGTH" or "EXACT_SCRAMBLE_LENGTH".


Reply to this email directly or view it on GitHubhttps://github.com/cubing/tnoodle/issues/158#issuecomment-31816055
.

@cs0x7f
Copy link
Contributor

cs0x7f commented Jan 8, 2014

The length includes tips. The filtering is correct.

@jfly
Copy link
Contributor Author

jfly commented Jan 8, 2014

I believe Chen Shuang is referring to the SCRAMBLE_LENGTH_INCLUDES_TIPS boolean in PyraminxPuzzle.java. I vaguely remember us having to deal with this.

@gregorbg gregorbg transferred this issue from thewca/tnoodle Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants