Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 and bigdecimal to the gemspec #134

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

hidakatsuya
Copy link
Member

This PR fixes #133

These gems will no longer be the default gem in the Ruby 3.4.

@hidakatsuya hidakatsuya self-assigned this Jan 6, 2024
These gems will no longer be the default gem in the Ruby 3.4
@hidakatsuya hidakatsuya force-pushed the dev/suppress-warning branch from 3075e60 to 5811d12 Compare January 6, 2024 09:34
@hidakatsuya hidakatsuya marked this pull request as ready for review January 6, 2024 09:35
@hidakatsuya hidakatsuya merged commit 712c9a7 into main Jan 6, 2024
8 checks passed
@hidakatsuya hidakatsuya deleted the dev/suppress-warning branch January 6, 2024 09:35
hswong3i added a commit to alvistack/hashicorp-vagrant that referenced this pull request May 11, 2024
base64 will no longer be the default gem in the Ruby 3.4, without this
patch following warning message may come from ruby 3.3+

    /opt/vagrant/lib/vagrant/util/powershell.rb:4: warning: base64 was
    loaded from the standard library, but will no longer be part of the
    default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

See thinreports/thinreports-generator#134

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings of base64 and bigdecimal will no longer be part of Ruby 3.4.0
1 participant