Drop dependency on httpoison, use hackney directly #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at this quickly on my phone and it seems good to me! I'll have to take a closer look on Friday when I have a bit more time but I think it'll be good to merge as-is. Thanks! |
| @@ -123,7 +130,7 @@ defmodule Bamboo.MailgunAdapter do | |||
| defp put_text_body(body, %Email{text_body: text_body}), do: Map.put(body, :text, text_body) | |||
|
|
|||
| defp full_uri(config) do | |||
| (Application.get_env(:bamboo, :mailgun_base_uri) || @base_uri) | |||
| <> config.domain <> "/messages" | |||
| [Application.get_env(:bamboo, :mailgun_base_uri) || @base_uri, | |||
There was a problem hiding this comment.
It seems strange that this return a list and not a string. Is that just a Hackney thing?
There was a problem hiding this comment.
hackney acceps iolists as url, I can revert it to append.
There was a problem hiding this comment.
I think I'd prefer that if it's cool with you :)
|
Just one question about using a list as the URI. Other than that, this looks great! |
michalmuskala
force-pushed
the
no-httpoison
branch
from
799bb49
to
ec317cd
Compare
|
@paulcsmith updated |
|
Thank you! :D Yay for one less dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one dependency from the project, and I don't think it complicates it in any significant way.