Allow to set mailgun config from env #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to have this PR merged. It's currently the standard way for deploying sensitive config data as part of Erlang releases. |
paulcsmith
reviewed
Nov 29, 2018
Apelsinka223
force-pushed
the
mailgun_config_from_env
branch
from
735b067
to
ad2bbeb
Compare
|
Hi @paulcsmith, made rebase |
|
Would love to see this merged 💖 |
maymillerricci
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to set config for mailgun adapter via env variables at runtime, by analogy with #342