Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sent_email_viewer] Remove whitespaces inside pre tag #493

Merged

Conversation

ymtszw
Copy link
Contributor

@ymtszw ymtszw commented Jul 22, 2019

Inside <pre> tags, whitespaces are shown literally. Thus rendered text bodies were "indented".

This PR removes whitespaces for indentation in <pre> tag from HTML-EEx source code.

Inside `<pre>` tags, whitespaces are shown literally. Thus rendered text bodies were "indented".

This PR removes whitespaces for indentation in `<pre>` tag from HTML-EEx source code.
@ymtszw
Copy link
Contributor Author

ymtszw commented Jul 22, 2019

The CI failure is from current master, not related to this branch.
Will follow when master is updated (or, please ignore since this PR does not change Elixir code anyway.)

Copy link
Contributor

@maymillerricci maymillerricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for this!

@maymillerricci maymillerricci merged commit e9ddba9 into beam-community:master Jul 26, 2019
@ymtszw ymtszw deleted the ymtszw-fix-indentation-in-pre-tag branch July 30, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants