Modify Runner to use Open3.capture3
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klaustopher does this PR resolve your noisy output issue? Does it fail-fast? |
seanpdoyle
force-pushed
the
errors-to-stderr
branch
from
0990a1c
to
33e2ad4
Compare
|
@thoughtbot/shell (sorry if this doesn't apply to all of you): Can someone well-versed in Ruby pipes help me modify this implementation to use Essentially, that PR “redirects” output from Ideally, we’d stream from |
|
@seanpdoyle yep, works fine ... Only outputs each error message once 👍 |
[`Open3.capture3`][docs] captures `STDOUT` and `STDERR`, allowing the `Runner` to manually redirect their output. This commit modified `Runner` to **only** output errors to `STDERR` (instead of to both `STDOUT` and `STDERR`). [docs]: http://ruby-doc.org/stdlib-1.9.3/libdoc/open3/rdoc/Open3.html#method-c-capture3
seanpdoyle
force-pushed
the
errors-to-stderr
branch
from
33e2ad4
to
8c6a208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open3.capture3capturesSTDOUTandSTDERR, allowing theRunnerto manually redirect their output.This commit modified
Runnerto only output errors toSTDERR(instead of to both
STDOUTandSTDERR).