Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farming Policies on testnet are broken #585

Closed
DylanVerstraete opened this issue Jan 18, 2023 · 4 comments
Closed

Farming Policies on testnet are broken #585

DylanVerstraete opened this issue Jan 18, 2023 · 4 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@DylanVerstraete
Copy link
Contributor

2 policies with the same ID

image

We can fix this by creating a migration which removes all data from the policies map and reinserts them with correct values

@DylanVerstraete DylanVerstraete added the type_bug Something isn't working label Jan 18, 2023
@renauter renauter self-assigned this Jan 19, 2023
@DylanVerstraete DylanVerstraete removed this from 3.10.x Jan 23, 2023
@DylanVerstraete DylanVerstraete moved this to 🔖 Accepted in 3.9.0 Jan 23, 2023
@DylanVerstraete DylanVerstraete modified the milestones: 2.2.0, 2.3.0 Jan 23, 2023
@renauter renauter moved this from 🔖 Accepted to 🏗 In progress in 3.9.0 Jan 23, 2023
@renauter
Copy link
Collaborator

Migration to fix farming policies ids was tested against testnet with command:

cargo run --release --features=try-runtime try-runtime --runtime target/release/wbuild/tfchain-runtime/tfchain_runtime.compact.wasm --chain chainspecs/main/chainSpecRaw.json on-runtime-upgrade live --uri ws://10.10.0.22:9944

See result here:

Screenshot from 2023-01-23 19-25-45

@renauter renauter moved this from 🏗 In progress to 👀 Verification in 3.9.0 Feb 3, 2023
@khaledyoussef24
Copy link

tested on devnet there is no duplicate ids
image

but it is still on testnet
Screenshot from 2023-03-06 11-14-21
@DylanVerstraete
will it be released now or with 3.9 ?

@DylanVerstraete
Copy link
Contributor Author

Yes

@A-Harby
Copy link

A-Harby commented Mar 16, 2023

be released now or with 3.9 ?

Verifying once released on testnet.

@A-Harby A-Harby closed this as completed Mar 16, 2023
@github-project-automation github-project-automation bot moved this from 👀 Verification to ✅ Done in 3.9.0 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants