Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-client: Add the ability to distinguish errors in EnsureAccount #985

Closed
AbdelrahmanElawady opened this issue Jul 4, 2024 · 1 comment
Closed

go-client: Add the ability to distinguish errors in EnsureAccount #985

AbdelrahmanElawady opened this issue Jul 4, 2024 · 1 comment
Assignees
@sameh-farouk
Labels
type_feature New feature or request
Milestone
2.9.0

Comments

@AbdelrahmanElawady
Copy link
Contributor

Is your feature request related to a problem? Please describe

When using the go-client there is no way to determine whether the error is related to tfchain or the activation service is down in EnsureAccount. Which makes it difficult to decide whether to retry another activation service or abort.

Describe the solution you'd like

Maybe add an exported error to indicate the error is due to activation service being down.
@AbdelrahmanElawady AbdelrahmanElawady added the type_feature New feature or request label Jul 4, 2024
@AbdelrahmanElawady AbdelrahmanElawady changed the title go-client: Add the ability to distinguish errors in EnsureAccount` go-client: Add the ability to distinguish errors in EnsureAccount Jul 4, 2024
@sameh-farouk sameh-farouk self-assigned this Jul 8, 2024
@sameh-farouk sameh-farouk added this to the 2.9.0 milestone Jul 8, 2024
@sameh-farouk sameh-farouk mentioned this issue Jul 9, 2024
Merged
2 tasks
@sameh-farouk
Copy link
Member

Can you please verify and close?
@AbdelrahmanElawady

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sameh-farouk sameh-farouk

Labels
type_feature New feature or request
Projects
3.15.x
Status: Done
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@sameh-farouk @AbdelrahmanElawady