Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect your wallet: green check for mnemonic while still validating the field #2588

Closed
xmonader opened this issue Apr 20, 2024 · 7 comments
Closed
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@xmonader
Copy link
Contributor

image

connect your wallet: green check for mnemonic while still validating the field

@ramezsaeed ramezsaeed added this to 3.14.x May 1, 2024
@ramezsaeed ramezsaeed added this to the 2.4.0 milestone May 1, 2024
@ramezsaeed ramezsaeed moved this to In Verification in 3.14.x May 1, 2024
@khaledyoussef24
Copy link
Contributor

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x May 2, 2024
@xmonader xmonader added type_bug Something isn't working type_feature New feature or request dashboard and removed type_feature New feature or request labels May 2, 2024
@khaledyoussef24
Copy link
Contributor

the issue still exists.
the message should appear before the green check.
Screenshot 2024-05-02 at 1 54 08 PM

@khaledyoussef24 khaledyoussef24 moved this from Done to Accepted in 3.14.x May 2, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.14.x May 2, 2024
@samaradel
Copy link
Contributor

Work Completed:

Display prepend icons in mnemonic input when it's valid and when it's not valid.

@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 2, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.14.x May 7, 2024
@khaledyoussef24
Copy link
Contributor

behavior improved
Screenshot 2024-05-08 at 9 21 27 AM
Screenshot 2024-05-08 at 9 12 33 AM
Screenshot 2024-05-08 at 9 12 59 AM

but creating an account now needs improvement after accepting the terms it shows the green check and the mnemonics is validated before they even get created.
Screenshot 2024-05-08 at 9 12 09 AM (2)

and i think this speed is acceptable
https://github.com/threefoldtech/tfgrid-sdk-ts/assets/110984055/c5e6b397-dc2e-4590-a01f-a9bcffc1463a

@khaledyoussef24
Copy link
Contributor

creating an account behavior needs to be changed so these messages and green checks shall only be visible after mnemonic is generated

Image

@samaradel samaradel moved this from In Verification to In Progress in 3.14.x May 8, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.14.x May 8, 2024
@samaradel
Copy link
Contributor

Work Completed:

  • Disable mnemonic validation when the account is created.
  • Reset mnemonic validation when creating a new account.

@MohamedElmdary MohamedElmdary moved this from Pending Review to In Verification in 3.14.x May 8, 2024
@A-Harby
Copy link
Contributor

A-Harby commented May 12, 2024

Verified, Devnet a4e4161.

The verification is removed from account generation, and is working fine with both mnemonic and hex in both keytype pairs.
image
image

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants