Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same master's filst when adding a new worker to kubernetes cluster #3320

Closed
AhmedHanafy725 opened this issue Aug 20, 2024 · 3 comments
Closed

Use the same master's filst when adding a new worker to kubernetes cluster #3320

AhmedHanafy725 opened this issue Aug 20, 2024 · 3 comments
Assignees
@maayarosama
Labels
grid_client type_feature New feature or request
Milestone
2.6.0

Comments

@AhmedHanafy725
Copy link
Contributor

threefoldtech/tf-images#292
@AhmedHanafy725 AhmedHanafy725 added type_feature New feature or request grid_client labels Aug 20, 2024
@AhmedHanafy725 AhmedHanafy725 added this to the 2.6.0 milestone Aug 28, 2024
@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.15.x Aug 28, 2024
@zaelgohary zaelgohary moved this from Accepted to Blocked in 3.15.x Aug 29, 2024
@AhmedHanafy725 AhmedHanafy725 moved this from Blocked to Accepted in 3.15.x Sep 18, 2024
@maayarosama maayarosama self-assigned this Sep 23, 2024
@maayarosama maayarosama moved this from Accepted to In Progress in 3.15.x Sep 23, 2024
@maayarosama maayarosama moved this from In Progress to Accepted in 3.15.x Sep 23, 2024
@maayarosama
Copy link
Contributor

Investigation and Solution:
Right now the Flist is hardcoded, still need to test what happens if I change it and add a new worker to an already existing cluster. Should be fixable by passing the master's flist to the worker as a parameter instead of a hard coded variable

@maayarosama maayarosama moved this from Accepted to In Progress in 3.15.x Sep 24, 2024
@maayarosama maayarosama mentioned this issue Sep 24, 2024
Merged
5 tasks
@maayarosama
Copy link
Contributor

Work Completed

Added a masterFlist var so when adding a worker the flist would be the same on the master

WIP

testing the solution

@maayarosama maayarosama moved this from In Progress to Pending Review in 3.15.x Sep 25, 2024
@AhmedHanafy725 AhmedHanafy725 mentioned this issue Sep 25, 2024
Closed
@maayarosama maayarosama moved this from Pending Review to In Verification in 3.15.x Sep 26, 2024
@khaledyoussef24
Copy link
Contributor

khaledyoussef24 commented Oct 18, 2024 •
edited
Loading

verified Flist of master and worker are the same
Version fccc6af

Image
Image
Image
Image
Image
testcase

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maayarosama maayarosama

Labels
grid_client type_feature New feature or request
Projects
3.15.x
Status: Done
Milestone
2.6.0
Development

No branches or pull requests
4 participants
@ramezsaeed @AhmedHanafy725 @maayarosama @khaledyoussef24