Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Create farm dialog not cleared after creating the farm #3470

Closed
1 task done
0oM4R opened this issue Sep 25, 2024 · 4 comments
Closed
1 task done

🐞 [Bug]: Create farm dialog not cleared after creating the farm #3470

0oM4R opened this issue Sep 25, 2024 · 4 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Sep 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

i craeted a farm name testlodge, the dialog got closed an toasts appeared then i tried to create another one but i found the old name in the input field with validation error name already exists

test case: https://app.testlodge.com/a/26076/projects/40893/runs/757884/run?run_suite_id=1250709&selected=33254467

Steps To Reproduce

  1. create a farm
  2. wait until the dialog got closed,
  3. click on create farm button, you will see the old farm name

which network/s did you face the problem on?

Dev

version

2.5.2

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Relevant log output

.
@0oM4R 0oM4R added the type_bug Something isn't working label Sep 25, 2024
@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Sep 29, 2024
@0oM4R
Copy link
Contributor Author

0oM4R commented Sep 29, 2024

on dialog close make sure to unmount the dialog to reset the fields

@0oM4R 0oM4R moved this to Accepted in 3.15.x Sep 29, 2024
@samaradel samaradel self-assigned this Oct 3, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Oct 3, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Oct 3, 2024
@samaradel
Copy link
Contributor

samaradel commented Oct 3, 2024

Work Completed:

Reset the farm name value in the create farm dialog on submit and on close.

@samaradel samaradel moved this from Pending Review to In Progress in 3.15.x Oct 9, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Oct 9, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.15.x Oct 13, 2024
@samaradel
Copy link
Contributor

Work Completed:

Remove props of the child as it's not usable in the parent (farm page) and refactor code.

@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Oct 13, 2024
@samaradel samaradel moved this from Pending Review to Pending Deployment in 3.15.x Oct 20, 2024
@samaradel samaradel moved this from Pending Deployment to In Verification in 3.15.x Oct 20, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
Version d757d29
Image
Image

testcase

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants