Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard : values file need to be improved #437

Closed
hossnys opened this issue May 31, 2023 · 1 comment
Closed

Dashboard : values file need to be improved #437

hossnys opened this issue May 31, 2023 · 1 comment
Assignees
@AhmedHanafy725
Labels
type_bug Something isn't working
Milestone
2.0.0

Comments

@hossnys
Copy link

hossnys commented May 31, 2023 •
edited
Loading

https://github.com/threefoldtech/tfgrid-sdk-ts/blob/v2.0.0-rc11/packages/dashboard/charts/tfgrid-dashboard/values.yaml#L107 , this line is not needed anymore as it's already be passed in env variables .
@hossnys hossnys changed the title Dashboard : Dashboard : values file need to be improved May 31, 2023
@AhmedHanafy725 AhmedHanafy725 self-assigned this Jun 1, 2023
@AhmedHanafy725 AhmedHanafy725 added the type_bug Something isn't working label Jun 1, 2023
@AhmedHanafy725 AhmedHanafy725 added this to the 2.0.0 milestone Jun 1, 2023
@AhmedHanafy725 AhmedHanafy725 mentioned this issue Jun 1, 2023
Merged
@AhmedHanafy725 AhmedHanafy725 moved this to In Progress in 3.10.x Jun 1, 2023
@AhmedHanafy725 AhmedHanafy725 moved this from In Progress to Verification in 3.10.x Jun 1, 2023
@mohamedamer453
Copy link
Contributor

Verified from https://github.com/threefoldtech/tfgrid-sdk-ts/blob/development/packages/dashboard/charts/tfgrid-dashboard/values.yaml

The mentioned value was removed.

@github-project-automation github-project-automation bot moved this from Verification to Done in 3.10.x Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmedHanafy725 AhmedHanafy725

Labels
type_bug Something isn't working
Projects
No open projects
3.10.x
Status: Done
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@hossnys @AhmedHanafy725 @mohamedamer453