Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard TFT price in dollar #441

Closed
A-Harby opened this issue May 31, 2023 · 11 comments
Closed

dashboard TFT price in dollar #441

A-Harby opened this issue May 31, 2023 · 11 comments
Assignees
@Mahmoud-Emad
Labels
dashboard type_bug Something isn't working
Milestone
2.0.0

Comments

@A-Harby
Copy link
Contributor

A-Harby commented May 31, 2023

Description

Devnet and Qanet 2.0.0-rc11
Should be 1 TFT not 0

image
@xmonader
Copy link
Contributor

سوسة اوي

@xmonader
Copy link
Contributor

apparently i verified on the devnet version
image

apologies

@xmonader xmonader added the type_bug Something isn't working label May 31, 2023
@xmonader xmonader added this to 3.10.x May 31, 2023
@xmonader xmonader moved this to In Progress in 3.10.x May 31, 2023
@xmonader xmonader added this to the 2.0.0 milestone May 31, 2023
@Mahmoud-Emad Mahmoud-Emad mentioned this issue May 31, 2023
Merged
5 tasks
@Mahmoud-Emad
Copy link
Contributor

should be fixed in #444

@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to Verification in 3.10.x May 31, 2023
@A-Harby
Copy link
Contributor Author

A-Harby commented Jun 1, 2023

Sidebar hides TFT amount when it expands
Untitled_ Jun 1, 2023 2_21 PM.webm

@A-Harby A-Harby moved this from Verification to In Progress in 3.10.x Jun 1, 2023
@Mahmoud-Emad Mahmoud-Emad mentioned this issue Jun 1, 2023
Merged
5 tasks
@Mahmoud-Emad
Copy link
Contributor

@A-Harby
Implemented in #460

@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to Verification in 3.10.x Jun 5, 2023
@xmonader
Copy link
Contributor

xmonader commented Jun 7, 2023

@A-Harby please reverify and close if all is ok

@A-Harby
Copy link
Contributor Author

A-Harby commented Jun 7, 2023

Issue was fixed and verified on localhost but its not released yet.
image

Should I close it or wait for the release?

@xmonader
Copy link
Contributor

xmonader commented Jun 7, 2023

Issue was fixed and verified on localhost but its not released yet. image

Should I close it or wait for the release?

How? I can see it on testnet deployment?
image

@Mahmoud-Emad
Copy link
Contributor

Mahmoud-Emad commented Jun 7, 2023 •
edited
Loading

@A-Harby
I would suggest trying to empty the cache and hot reload. Sometimes that can help resolve issues with loading or performance. Have you tried that yet?

@Mahmoud-Emad
Copy link
Contributor

Just an update, this issue arose after we released the QA version. Therefore, it has been fixed on the development version instead of the QA version. Apologies for any confusion caused. :)

@A-Harby
Copy link
Contributor Author

A-Harby commented Jun 20, 2023

Verified, on QA 2.0.0-rc14.
Space is correct and doesn't disappear with sidemenu open
image

@A-Harby A-Harby closed this as completed Jun 20, 2023
@github-project-automation github-project-automation bot moved this from Verification to Done in 3.10.x Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mahmoud-Emad Mahmoud-Emad

Labels
dashboard type_bug Something isn't working
Projects
No open projects
3.10.x
Status: Done
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@xmonader @AhmedHanafy725 @Mahmoud-Emad @A-Harby