Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit button validation on adding node public config without IPV6 #52

Closed
A-Harby opened this issue Mar 21, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Mar 21, 2023

Description

When adding node public config, all the input must be filled in for the submit button to be enabled.
But when you fill in all of them and the button is enabled you can now then removed IPV6 or the IPV6 gateway and the button will still be enabled

Steps to reproduce

When you fill in all the inputs
image

When you remove one of them
image
image

Will give this error in the console when submit without only one of them.
image

@rkhamis rkhamis transferred this issue from threefoldtecharchive/tfgrid_dashboard Apr 13, 2023
@AhmedHanafy725 AhmedHanafy725 added this to the 2.1.0 milestone Apr 17, 2023
@0oM4R 0oM4R self-assigned this May 2, 2023
@0oM4R 0oM4R moved this to In Progress in 3.11.x May 2, 2023
@0oM4R 0oM4R moved this from In Progress to Verification in 3.11.x May 3, 2023
@0oM4R 0oM4R moved this from Verification to In Progress in 3.11.x May 9, 2023
@0oM4R 0oM4R moved this from In Progress to Verification in 3.11.x May 10, 2023
@mohamedamer453
Copy link
Contributor

Verified on devnet.

Now when the user enters anything in the IPV6 the GW6 field becomes mandatory and vice versa. and it's only optional when both fields are empty.

Screencast.from.11-06-23.18.09.48.webm

@github-project-automation github-project-automation bot moved this from Verification to Done in 3.11.x Jun 11, 2023
@AhmedHanafy725 AhmedHanafy725 removed this from 3.11.x Jun 14, 2023
@AhmedHanafy725 AhmedHanafy725 moved this to Done in 3.10.x Jun 14, 2023
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.1.0, 2.0.0 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants