Public IPs validation isn't working correctly

[A-Harby]

Description

Keep getting failing to add public config to your node without explain why and without any validation errors.
After testing every input to accept config, IPV4 was the reason.
e.g. 23.24.221.243/30

Logs/Alerts

Untitled_.Dec.27.2022.6_57.PM.webm

[coesensbert]

Not sure it's the reason but your ipv4 address is not correct if the subnet mask is /30.
The only free ip's in that range are 23.24.221.241 - 23.24.221.242
So the ip needs to be one of the two (not 23.24.221.243), and the gateway (can never be 1.1.1.1) also.

Ipv6 too, ::5/26 can never work online

I would guess the on-chain ip check would refuse such config's.

[A-Harby]

Faced same issue with Add Public IP to Farm, Validation passed but adding IP failed.

So I think public IPV4 and IPV6 needs some kind of public IP checker.

[DylanVerstraete]

@A-Harby status?

[A-Harby]

@A-Harby status?

The problem was with dashboard input validation rather than TFChain validation.
The inputs don't check if an IP is public or not, and they allow it then it fails to add the IP from TFChain (and the alarms don't specify what caused the failure).

[xmonader]

Validation should be the following if the IP falls in 192.168.0.0/24 ,172.16.0.0 - 172.31.255.255 and 10.0.0.0/8 also regex logic would be cumbersome, I believe it should be done by creating a network object and checking if the ip falls in that range

[A-Harby]

Verified on Devnet, v1.4.0-rc4.

Private IPs are now blocked from being added with alert message 'IP/Gateway is not public' added to clarify.