Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Public key missing from new twin on testnet #630

Closed
scottyeager opened this issue Apr 10, 2023 · 4 comments
Closed

Public key missing from new twin on testnet #630

scottyeager opened this issue Apr 10, 2023 · 4 comments
Labels
type_bug Something isn't working

Comments

@scottyeager
Copy link

I've created a new twin on testnet using the dashboard, with id 919. It does not have a public key filled in, thus cannot participate in RMB communication. Seen here, along with another example provided by another user:

image

We'll need a way to correct this on any twins created without a key so far, as well as fixing it for twins created in the future.

@muhamadazmy
Copy link

This is not an issue, because the twin on tfchain (substrate) also has also no public key. the public key is optional and is only needed if the twin wants to use end to end encryption hence not all twins has to have a pk

Also note that those twins are NOT associated with nodes. those twins are probably used by clients (and not nodes) that don't want e2e (or don't support it)

@scottyeager
Copy link
Author

Thanks for weighing in, @muhamadazmy. I had assumed that the key would always be set at the time of twin creation, or in the case of existing twins, when setting the relay.

In this case, I used my other twin for testing farmerbot, so the rmb-peer had set the public key. Only twins with a previously set public key are working in the testnet playground, so it seems the real issue is that the playground should be checking and setting the key if needed. I'll follow up there.

@AhmedHanafy725
Copy link
Contributor

AhmedHanafy725 commented Apr 11, 2023

the newly created twins from the dashboard yes don't have the publicKey set as we don't have the mnemonics. #545 (comment)
but it will be updated once it's used in the clients (go rmb client, ts rmb client, or rmb-peer). the playground is using the ts rmb client, so once the mnemonic is set there, it will be automatically updated with the public key

I just tried it on testnet to make sure and it worked
image

@scottyeager
Copy link
Author

Hi @AhmedHanafy725,

We have several reports, including my own experience, that the playground is not setting the public key (threefoldtech/tfgrid-sdk-ts#73). I'll keep collecting examples and update the issue on the weblet repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants