Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest versions of jQuery and lightgallery #3

Open
oliworx opened this issue Mar 20, 2021 · 1 comment
Open

Upgrade to latest versions of jQuery and lightgallery #3

oliworx opened this issue Mar 20, 2021 · 1 comment

Comments

@oliworx
Copy link

oliworx commented Mar 20, 2021

should not be a big deal,
as I already did it in this cloned theme: https://github.com/oliworx/theme-classic

@rprieto
Copy link
Member

rprieto commented Apr 9, 2021

Hi, this is a good idea. It would solve issues like thumbsup/thumbsup#248.

Unfortunately LightGallery switched to a GPL license after version 1.2. As far as I understand, newer versions cannot be included in Thumbsup anymore (which is MIT licensed). I raised this in sachinchoolur/lightGallery#256 but we couldn't find a solution.

I'm open to any ideas on how to integrate with a GPL solution. For example, the themes could switch to GPL, and be downloaded dynamically instead of being bundled, such as --theme @thumbsup/classic. However it would require an internet connexion, which is not needed today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants