-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 8.1 #2
Comments
Found issue. For Windows 8.1 with "Windows NT 6.3" userAgent, the ua-parser sets Major to an "8.1" float when it should be Major "8" integer and Minor "1" integer. Code on our side does an int() conversion on Major and fails. |
Created ticket |
Hi thyn, Thank you for the ticket. Issue also exists for "XP" which should be put in as 6.0, or "Vista" as 6.1, and help me if people still use it, but I wouldn't bother with Windows ME or 95/98/98SE :) We modified our table to store as nvarchar(20) for now on OsMajor instead of an int(), as showing "Windows 6.0" will probably be confusing for people. They will instantly recognize "XP", so maybe an OsFriendly output alongside OsMajor/OsMinor would fix that, but just thinking out loud here. |
was fixed about a year ago |
Noticed something weird that Windows 8.1 user-agent strings are not parsed.
Examples of those that seem to fail:
I can provide more details if needed.
The text was updated successfully, but these errors were encountered: