Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix SQLAlchemy version 1.4.36 breaks SQLModel relationships (#315) #461

Merged
merged 6 commits into from
Oct 22, 2023

Conversation

byrman
Copy link
Contributor

@byrman byrman commented Oct 8, 2022

A previous fix was incomplete as it did not cover this use case: #315 (comment).

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (2d6e7a1) 98.49%.
Report is 38 commits behind head on main.

❗ Current head 2d6e7a1 differs from pull request most recent head 512482c. Consider uploading reports for the commit 512482c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files         185      185           
  Lines        5856     5856           
=======================================
  Hits         5768     5768           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

📝 Docs preview for commit b7b2796 at: https://6341576bac2fc7202f08e3fb--sqlmodel.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

📝 Docs preview for commit 2f16326 at: https://6342ba1df9dc760c2d8ebc97--sqlmodel.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

📝 Docs preview for commit 2d6e7a1 at: https://6342be03d6cd7b1206f4900e--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 72735d7 at: https://636e6a5108e2d408b4242b75--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit b81b1cc at: https://639ce06604b775008e17a610--sqlmodel.netlify.app

@tiangolo
Copy link
Member

I was finally able to check it, the tests, etc. Thank you @byrman! This will be available in SQLModel 0.0.9 in the next hours. 🚀

@tiangolo tiangolo merged commit d5219aa into fastapi:main Oct 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants