Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing prog_name #120

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Conversation

teymour-aldridge
Copy link
Contributor

This fixes #118.

@tarcisioe
Copy link

tarcisioe commented Jun 22, 2020

It seems that you ran isort (likely with a different configuration than the one this project uses) over the whole tests directory, changing some files that weren't related to this PR. Only prog_name.py needed to have typer imported after subprocess, the rest can (should, I guess) be reverted.

@teymour-aldridge teymour-aldridge force-pushed the pass-prog-name branch 2 times, most recently from 79e6a8f to cd8dc68 Compare June 23, 2020 09:46
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          214       216    +2     
  Lines         4046      4057   +11     
=========================================
+ Hits          4046      4057   +11     
Impacted Files Coverage Δ
tests/assets/prog_name.py 100.00% <100.00%> (ø)
tests/test_prog_name.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45fb7c4...11e6aef. Read the comment docs.

@tiangolo tiangolo merged commit 4ed37fe into fastapi:master Jun 23, 2020
@tiangolo
Copy link
Member

Great! Thank you @teymour-aldridge ! 🚀

Thanks for the help @tarcisioe ! 🙇

I just updated the tests a bit to use the same structure as the other tests and to run using coverage instead of python, that way the coverage can be updated.

Thanks for your contribution! 🚀 🎉 🍰

@teymour-aldridge
Copy link
Contributor Author

You're most welcome!
Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Is there a better way to pass prog_name without going through the Click command?
3 participants