🐛 Fix broken installation when upgrading from typer <0.12.0 to typer >=0.12.0, make typer independent of typer-slim, include typer command in typer package
#791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same pyproject.toml
…project.toml configs
…tend, make packages independent
|
📝 Docs preview for commit 0f3fb31 at: https://f5e89068.typertiangolo.pages.dev |
|
📝 Docs preview for commit 4051ad1 at: https://d3e6e116.typertiangolo.pages.dev |
|
📝 Docs preview for commit b3b823b at: https://fbfdd558.typertiangolo.pages.dev |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix broken installation when upgrading from
typer <0.12.0totyper >=0.12.0, maketyperindependent oftyper-slim, includetypercommand intyperpackage.This would solve the issue #790
Current state as of
0.12.0Since version
0.12.0, thetyperpip installable package doesn't include thetyperPython importable package/module, instead it declares it depends on the pip installable packagetyper-slim[standard], to include thestandardextras.And the pip installable package
typer-slimis the one that provides the Python importabletyperpackage/module.But this is problematic for old installations, because of the way package managers handle them, they install
typer-slim, including thetyperdirectory with the code, then they remove the oldtyperpackage with its associated files, which means removing almost all the files in thetyperdirectory, only leaving the new files since version0.12.0.In this PR
Now the pip installable
typerincludes all the dependencies intyper-slim, plus the dependencies defined intyper-slim[standard]. So,typerno longer depends ontyper-slim. And the pip installabletyperpackage includes the code, the Python importable package/moduletyper. Nowtyperincludes thetypercommand.And
typer-slimincludes the same, but without installing the optional dependencies by default, only including an optional dependencies groupstandard(withrichandshellingham).Now
typer-clidoesn't really do anything, it's there only for backwards compatibility, for a bit, for those that could have it as a dependency. Typer now includes thetypercommand.