Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Generalize test suite to run on Windows #810

Merged
merged 3 commits into from
May 2, 2024

Conversation

svlandeg
Copy link
Member

Ensure that the test suite runs properly on Windows by:

  • adding quotes when paths can have spaces or backslashes
  • using Pathlib to automatically parse the correct path separator, rather than relying on the literal string "/"

Related PR: #809

@svlandeg svlandeg added p3 repo / tests Involving the CI / test suite labels Apr 25, 2024
@tiangolo
Copy link
Member

tiangolo commented May 2, 2024

Awesome, thank you! 🚀

@tiangolo tiangolo merged commit 77adc6e into fastapi:master May 2, 2024
18 checks passed
@svlandeg svlandeg deleted the feat/generalize_test_suite branch May 3, 2024 07:26
@svlandeg svlandeg added the os / windows Related to Windows label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal os / windows Related to Windows p3 repo / tests Involving the CI / test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants