Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package #1

Closed
stefanb opened this issue Jun 25, 2024 · 2 comments
Closed

Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package #1

stefanb opened this issue Jun 25, 2024 · 2 comments

Comments

@stefanb
Copy link

stefanb commented Jun 25, 2024 •
edited
Loading

While testing Go 1.23 rc1 in

there was an error:

  # github.com/tickstep/aliyunpan
  link: github.com/tickstep/library-go/cachepool: invalid reference to runtime.rawbyteslice

Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see

It is used in
https://github.com/tickstep/library-go/blob/49613680e69f5fa832a5ea0b13dc68b58e9000a8/cachepool/malloc.go#L12C3-L18
@stefanb stefanb changed the title Go 1.23 doesn't allow //go:linkname to internal symbols, including to runtime package Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package Jun 25, 2024
This was referenced Jun 30, 2024
Closed
Open
@stefanb
Copy link
Author

stefanb commented Jul 18, 2024 •
edited
Loading

Build is still failing with Go 1.23 rc2.

@tickstep
Copy link
Owner

fix it in the latest verison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanb @tickstep