ci: use macos-13 to run ci #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or, give up on v3 in |
|
Downloading the binding folder it looks to build correctly |
cb1kenobi
approved these changes
Jul 12, 2024
|
@cb1kenobi I can try that out but I'd prefer to get a fixed version of this so that we can have something functional and then refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with compiling node-ios-device for x64 on arm64 machines, unfortunately all MacOS 14 runners on GitHub are now arm64 based so we have to drop down to MacOS 13. We can verify it builds ok using the artifacts produced.
Realistically, this is a bandaid not a fix. There might be a genuine fix we can perform in the build logic but this is hopefully faster.