Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDD prep: redocument() with new roxygen #117

Merged
merged 4 commits into from
Aug 6, 2024
Merged

TDD prep: redocument() with new roxygen #117

merged 4 commits into from
Aug 6, 2024

Conversation

simonpcouch
Copy link
Contributor

Also ensures that GHA are running fine.

@simonpcouch
Copy link
Contributor Author

cc @topepo, there's a test here called "one player is really bad" that's now failing with:

── Failure ('test-win-loss-overall.R:92:3'): one player is really bad ──────────
nrow(best_res) == 1 is not TRUE

`actual`:   FALSE
`expected`: TRUE 

best_res actually looks like:

best_res
#> # A tibble: 2 × 7
#>   min_n .metric .estimator  mean     n std_err .config             
#>   <dbl> <chr>   <chr>      <dbl> <int>   <dbl> <chr>               
#> 1   400 roc_auc binary     0.820    10  0.0231 Preprocessor1_Model2
#> 2     1 roc_auc binary     0.815    10  0.0185 Preprocessor1_Model1

Any intuition?

@simonpcouch simonpcouch merged commit 2c6d162 into main Aug 6, 2024
8 checks passed
@simonpcouch simonpcouch deleted the tdd-redoc branch August 6, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant