Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in documentation for learn_rate for brulee MLP #1018

Closed
era127 opened this issue Nov 4, 2023 · 2 comments · Fixed by #1020
Closed

error in documentation for learn_rate for brulee MLP #1018

era127 opened this issue Nov 4, 2023 · 2 comments · Fixed by #1020

Comments

@era127
Copy link

era127 commented Nov 4, 2023

I think there is an error in the documentation for the learn_rate param in details_mlp_brulee. I think the learn_rate should be 0.01 not 100L, and epochs should be 100L.

I see the documentation in this file: man/rmd/mlp_brulee.Rmd

defaults <- 
  tibble::tibble(parsnip = c("hidden_units", "penalty", "dropout", "epochs", "learn_rate", "activation", "mixture"),
                 default = c("3L", "0.0", "0.0", "0.01", "100L", "'relu'", "0.0"))

param <-
  mlp() %>% 
  set_engine("brulee") %>% 
  make_parameter_list(defaults)
@hfrick
Copy link
Member

hfrick commented Nov 6, 2023

Thanks for the report @rdavis120 !

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants