From 3dff344001fb732e37a63a0e8e4922f67d71678b Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Mon, 20 Sep 2021 16:11:33 -0600 Subject: [PATCH] Escalate deprecation for gather.rset --- NEWS.md | 2 ++ R/gather.R | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 2156bef1..a037b11f 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,8 @@ * Change `make_splits()` to an S3 generic, with the original functionality a method for `list` and a new method for dataframes that allows users to create a split from existing analysis & assessment sets (@LiamBlake, #246). +* Escalated the deprecation of the `gather()` method for `rset` objects to a hard deprecation. Use `tidyr::pivot_longer()` instead (#257). + # rsample 0.1.0 * Fixed how `mc_cv()`, `initial_split()`, and `validation_split()` use the `prop` argument to first compute the assessment indices, rather than the analysis indices. This is a minor but **breaking change** in some situations; the previous implementation could cause an inconsistency in the sizes of the generated analysis and assessment sets when compared to how `prop` is documented to function (#217, @issactoast). diff --git a/R/gather.R b/R/gather.R index ad096b36..3af49530 100644 --- a/R/gather.R +++ b/R/gather.R @@ -48,7 +48,7 @@ gather.rset <- function(data, key = NULL, value = NULL, ..., na.rm = TRUE, convert = FALSE, factor_key = TRUE) { - lifecycle::deprecate_warn("0.1.0", "gather.rset()", "tidyr::pivot_longer()") + lifecycle::deprecate_stop("0.1.0", "gather.rset()", "tidyr::pivot_longer()") if (any(names(data) == "splits")) { data <- data %>% dplyr::select(-splits)