Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIFs in the Buffering article have not updated to the new autoplot #88

Open
mikemahoney218 opened this issue Jun 21, 2022 · 4 comments
Open

Comments

@mikemahoney218
Copy link
Member

Both the main and dev site still use the old (fully opaque) autoplot method for buffering GIFs:
https://spatialsample.tidymodels.org/dev/articles/buffering.html

I'm not entirely sure why that's happening; I guess we need to do something to force a re-render.

@juliasilge
Copy link
Member

I have heard people say that this lets us trigger a render:


But honestly I have never gotten it to work and I'm not sure what to do.

@mikemahoney218
Copy link
Member Author

Ooh! I didn't realize this had that under on.

That gives you this drop-down on the Actions page when you click into a given workflow:
Screenshot from 2022-06-21 14-35-46

I used it to kick a job over at https://github.com/tidymodels/spatialsample/actions/runs/2537504246 🤞

@mikemahoney218
Copy link
Member Author

Didn't seem to help, unfortunately -- both the dev and main sites are still fully opaque. Will investigate further.

@mikemahoney218
Copy link
Member Author

Alright, after poking around I can confirm it's not the following things:

  1. Locally, the PNGs are transparent but the pkgdown vignette GIFs are not. So it's not the autoplot method.
  2. GHA has Cairo, so it's not that https://github.com/tidymodels/spatialsample/runs/7030251017?check_suite_focus=true#step:6:13
  3. ggsave on GHA preserves transparency, so it's not that https://github.com/tidymodels/spatialsample/actions/runs/2551516725
  4. Using a different device (namely ragg::agg_png) doesn't change things, so it's not that

The speculation (from Hadley and Christophe) is that it may be due to looping through the plots via walk, but we haven't found any concrete problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants