From c97615e6f4e53842c18c332c34c0a5f44fee4144 Mon Sep 17 00:00:00 2001 From: simonpcouch Date: Thu, 21 Mar 2024 11:57:54 -0500 Subject: [PATCH 1/4] adjust redirecting URL --- README.Rmd | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.Rmd b/README.Rmd index 45e7951d..c39a2943 100644 --- a/README.Rmd +++ b/README.Rmd @@ -81,7 +81,7 @@ The full visual outline for these steps can be found [here](https://github.com/t This project is released with a [Contributor Code of Conduct](https://github.com/tidymodels/stacks/blob/main/.github/CODE_OF_CONDUCT.md). By contributing to this project, you agree to abide by its terms. -- For questions and discussions about tidymodels packages, modeling, and machine learning, please [post on Posit Community](https://community.rstudio.com/new-topic?category_id=15&tags=tidymodels,question). +- For questions and discussions about tidymodels packages, modeling, and machine learning, please [post on Posit Community](https://forum.posit.co/new-topic?category_id=15&tags=tidymodels,question). - If you think you have encountered a bug, please [submit an issue](https://github.com/tidymodels/stacks/issues). diff --git a/README.md b/README.md index f0268958..20896fe2 100644 --- a/README.md +++ b/README.md @@ -176,7 +176,7 @@ By contributing to this project, you agree to abide by its terms. - For questions and discussions about tidymodels packages, modeling, and machine learning, please [post on Posit - Community](https://community.rstudio.com/new-topic?category_id=15&tags=tidymodels,question). + Community](https://forum.posit.co/new-topic?category_id=15&tags=tidymodels,question). - If you think you have encountered a bug, please [submit an issue](https://github.com/tidymodels/stacks/issues). From 5e6fe4def62c768a5d7ad6b17b1686d943b75f17 Mon Sep 17 00:00:00 2001 From: simonpcouch Date: Thu, 21 Mar 2024 12:08:59 -0500 Subject: [PATCH 2/4] transition yardstick to Suggests avoid the 20+ dependency NOTE --- DESCRIPTION | 6 +++--- NAMESPACE | 1 - R/utils.R | 5 ----- tests/testthat/test_add_candidates.R | 2 ++ tests/testthat/test_blend_predictions.R | 2 ++ vignettes/classification.Rmd | 5 +++-- 6 files changed, 10 insertions(+), 11 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 5bee0c14..88df690c 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -37,8 +37,7 @@ Imports: tidyr, tune (>= 1.2.0), vctrs (>= 0.6.1), - workflows (>= 1.1.4), - yardstick (>= 1.1.0) + workflows (>= 1.1.4) Suggests: covr, h2o, @@ -51,7 +50,8 @@ Suggests: ranger, rmarkdown, testthat (>= 3.0.0), - workflowsets (>= 0.1.0) + workflowsets (>= 0.1.0), + yardstick (>= 1.1.0) VignetteBuilder: knitr Config/Needs/website: tidyverse/tidytemplate diff --git a/NAMESPACE b/NAMESPACE index 1e42dde9..252f6393 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -77,4 +77,3 @@ importFrom(ggplot2,autoplot) importFrom(rlang,"%||%") importFrom(rlang,caller_env) importFrom(stats,predict) -importFrom(yardstick,metric_set) diff --git a/R/utils.R b/R/utils.R index 02c44f13..32c60e9e 100644 --- a/R/utils.R +++ b/R/utils.R @@ -163,8 +163,3 @@ mode_is_regression <- function(x) { } x } - -# quiet R-CMD-check NOTEs that yardstick is unused -# (see example data .Rmds for usage) -#' @importFrom yardstick metric_set -NULL diff --git a/tests/testthat/test_add_candidates.R b/tests/testthat/test_add_candidates.R index f8c890af..775e0245 100644 --- a/tests/testthat/test_add_candidates.R +++ b/tests/testthat/test_add_candidates.R @@ -18,6 +18,8 @@ library(kernlab) skip_if_not_installed("nnet") library(nnet) +skip_if_not_installed("yardstick") + test_that("stack can add candidates (regression)", { skip_on_cran() diff --git a/tests/testthat/test_blend_predictions.R b/tests/testthat/test_blend_predictions.R index b6e7d01b..fb1c17f6 100644 --- a/tests/testthat/test_blend_predictions.R +++ b/tests/testthat/test_blend_predictions.R @@ -18,6 +18,8 @@ library(kernlab) skip_if_not_installed("nnet") library(nnet) +skip_if_not_installed("yardstick") + test_that("blend_predictions works", { skip_on_cran() diff --git a/vignettes/classification.Rmd b/vignettes/classification.Rmd index 187101df..6bd28125 100644 --- a/vignettes/classification.Rmd +++ b/vignettes/classification.Rmd @@ -27,7 +27,6 @@ library(rsample) library(parsnip) library(workflows) library(recipes) -library(yardstick) library(stacks) library(purrr) library(dplyr) @@ -38,8 +37,10 @@ library(ggplot2) ```{r, include = FALSE} if (rlang::is_installed("ranger") && rlang::is_installed("nnet") && - rlang::is_installed("kernlab")) { + rlang::is_installed("kernlab") && + rlang::is_installed("yardstick")) { run <- TRUE + library(yardstick) } else { run <- FALSE } From 8ef7138ac941461df08f85bdde04b3a5c9009a55 Mon Sep 17 00:00:00 2001 From: simonpcouch Date: Thu, 21 Mar 2024 12:52:14 -0500 Subject: [PATCH 3/4] update revdep number --- cran-comments.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cran-comments.md b/cran-comments.md index 9c5ebe0f..c206344d 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -4,4 +4,4 @@ There were no ERRORs, WARNINGs, or NOTEs. ## Reverse dependencies -We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package, and saw no new problems. +We checked 5 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package, and saw no new problems. From 0e01fcad507d691d332c4f1739845436dc85d08c Mon Sep 17 00:00:00 2001 From: simonpcouch Date: Thu, 21 Mar 2024 12:52:41 -0500 Subject: [PATCH 4/4] Increment version number to 1.0.4 --- DESCRIPTION | 2 +- NEWS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 88df690c..af035cdc 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: stacks Title: Tidy Model Stacking -Version: 1.0.3.9001 +Version: 1.0.4 Authors@R: c( person("Simon", "Couch", , "simon.couch@posit.co", role = c("aut", "cre")), person("Max", "Kuhn", , "max@posit.co", role = "aut"), diff --git a/NEWS.md b/NEWS.md index 04960154..fe5c02d5 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# stacks (development version) +# stacks 1.0.4 * Introduced support for parallel processing using the [future](https://www.futureverse.org/) framework. The stacks package previously supported parallelism with foreach, and users can use either framework for now. In a future release, stacks will begin the deprecation cycle for parallelism with foreach, so we encourage users to begin migrating their code now. See [the _Parallel Processing_ section in the tune package's "Optimizations" article](https://tune.tidymodels.org/articles/extras/optimizations.html#parallel-processing) to learn more (#866).