Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example data objects for new recipes #203

Closed
juliasilge opened this issue Oct 31, 2023 · 3 comments
Closed

Update example data objects for new recipes #203

juliasilge opened this issue Oct 31, 2023 · 3 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@juliasilge
Copy link
Member

I use some of the stacks data objects like reg_res_lr in setting up tests in vetiver, and I see these warnings about keep_original_cols:

library(stacks)

data("tree_frogs", package = "stacks")
tree_test <- tree_frogs %>%
    dplyr::select(-hatched, -latency, -clutch)

frog_reg <-
    stacks() %>%
    add_candidates(reg_res_lr) %>%
    add_candidates(reg_res_sp) %>%
    blend_predictions(penalty = 20) %>%
    fit_members()
#> Warning: 'keep_original_cols' was added to `step_ns()` after this recipe was created.
#> Regenerate your recipe to avoid this warning.
#> 'keep_original_cols' was added to `step_ns()` after this recipe was created.
#> Regenerate your recipe to avoid this warning.
#> 'keep_original_cols' was added to `step_ns()` after this recipe was created.
#> Regenerate your recipe to avoid this warning.

Created on 2023-10-31 with reprex v2.0.2

Do you think these objects could be regenerated so they don't generate warnings with the current version of recipes?

@simonpcouch
Copy link
Collaborator

Absolutely. Will loop this into stacks' spring cleaning and put together a release with changes from the last few months after then. :)

@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Nov 1, 2023
@simonpcouch
Copy link
Collaborator

Will wait a few days before sending these changes off to CRAN, @juliasilge—feel free to holler if this doesn't do the trick for your tests, but it resolved the same issue in stacks' tests!

@juliasilge
Copy link
Member Author

Perfect! Thank you so much 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants