From 7b2ca00ad936104f4835b5edf3f6020864f97b07 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 16 May 2024 12:09:39 +0800 Subject: [PATCH 1/6] just go back --- src/pages/ReportDetailsPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index ca66a0e97bb5..8be0e40305c9 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -268,7 +268,6 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD From 613e3aecaf80bc9a33eba803ae6cecf924694fb6 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 16 May 2024 12:41:24 +0800 Subject: [PATCH 2/6] remove unused variable --- src/pages/ReportDetailsPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index 8be0e40305c9..a5f800c702a6 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -64,7 +64,6 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD const {translate} = useLocalize(); const {isOffline} = useNetwork(); const styles = useThemeStyles(); - const route = useRoute(); const policy = useMemo(() => policies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID ?? ''}`], [policies, report?.policyID]); const isPolicyAdmin = useMemo(() => PolicyUtils.isPolicyAdmin(policy ?? null), [policy]); const isPolicyEmployee = useMemo(() => PolicyUtils.isPolicyEmployee(report?.policyID ?? '', policies), [report?.policyID, policies]); From 4f84ec1f4b344dd98cac24ce70707520c265f728 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 16 May 2024 12:53:55 +0800 Subject: [PATCH 3/6] remove unused import --- src/pages/ReportDetailsPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index a5f800c702a6..793684af4ecd 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -1,4 +1,3 @@ -import {useRoute} from '@react-navigation/native'; import type {StackScreenProps} from '@react-navigation/stack'; import React, {useEffect, useMemo} from 'react'; import {View} from 'react-native'; From 5a7e1493dff7352d046ce0aabfd143679214985c Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Mon, 20 May 2024 17:02:33 +0800 Subject: [PATCH 4/6] use the default props --- src/pages/ReportDetailsPage.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/pages/ReportDetailsPage.tsx b/src/pages/ReportDetailsPage.tsx index 793684af4ecd..783b78ef51d9 100644 --- a/src/pages/ReportDetailsPage.tsx +++ b/src/pages/ReportDetailsPage.tsx @@ -263,10 +263,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD return ( - + From b1229a47f0742ff7b9d7334e1c55427c204d466b Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Mon, 20 May 2024 17:03:02 +0800 Subject: [PATCH 5/6] fix going back from flag comment removes the linked action --- src/pages/FlagCommentPage.tsx | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/pages/FlagCommentPage.tsx b/src/pages/FlagCommentPage.tsx index 53aac0ce2a8b..e30ac2a319d6 100644 --- a/src/pages/FlagCommentPage.tsx +++ b/src/pages/FlagCommentPage.tsx @@ -160,14 +160,7 @@ function FlagCommentPage({parentReportAction, route, report, parentReport, repor > {({safeAreaPaddingBottomStyle}) => ( - { - Navigation.goBack(); - Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report?.reportID ?? '')); - }} - /> + Date: Mon, 20 May 2024 17:10:27 +0800 Subject: [PATCH 6/6] remove unused import --- src/pages/FlagCommentPage.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/FlagCommentPage.tsx b/src/pages/FlagCommentPage.tsx index e30ac2a319d6..98fe3973ff9d 100644 --- a/src/pages/FlagCommentPage.tsx +++ b/src/pages/FlagCommentPage.tsx @@ -19,7 +19,6 @@ import * as ReportUtils from '@libs/ReportUtils'; import * as Report from '@userActions/Report'; import * as Session from '@userActions/Session'; import CONST from '@src/CONST'; -import ROUTES from '@src/ROUTES'; import type SCREENS from '@src/SCREENS'; import type * as OnyxTypes from '@src/types/onyx'; import withReportAndReportActionOrNotFound from './home/report/withReportAndReportActionOrNotFound';