Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use monotonic clock to ensure TSO safty #1661

Closed
disksing opened this issue Aug 1, 2019 · 0 comments · Fixed by #1676
Closed

Use monotonic clock to ensure TSO safty #1661

disksing opened this issue Aug 1, 2019 · 0 comments · Fixed by #1676
Labels
status/discussion-wanted The issue needs to be discussed. type/enhancement The issue or PR belongs to an enhancement.

Comments

@disksing
Copy link
Contributor

disksing commented Aug 1, 2019

During leader election, the TSO could be corrupted if the notify message of keep alive channel is not received in time. On this situation, old leader and new leader can serve timestamps at the same time.
Possible fix: Store lease expire time (in monotonic_raw fashion) and check lease for every received GetTS requests.
@disksing disksing added type/enhancement The issue or PR belongs to an enhancement. status/discussion-wanted The issue needs to be discussed. labels Aug 1, 2019
@disksing disksing mentioned this issue Aug 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/discussion-wanted The issue needs to be discussed. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: use leader lease to determine tso service validity oh-my-tidb/pd
1 participant
@disksing