Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the metrics of store state filter #2933

Closed
rleungx opened this issue Sep 9, 2020 · 0 comments · Fixed by #2946
Closed

Improve the metrics of store state filter #2933

rleungx opened this issue Sep 9, 2020 · 0 comments · Fixed by #2946
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Sep 9, 2020 •
edited
Loading

We have some metrics to help us locate the reason why the scheduling source or target is filtered. e.g.

Screen Shot 2020-09-09 at 11 01 37 AM

There is an item named *-store-state-filter which contains many situations, but we cannot distinguish them through the monitor directly.

The logic of the store state filter can be found in https://github.com/tikv/pd/blob/master/server/schedule/filter/filters.go#L220-L358, The metrics related logic can be found in https://github.com/tikv/pd/blob/master/server/schedule/filter/filters.go#L66-L90
@rleungx rleungx added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 9, 2020
@rleungx rleungx mentioned this issue Sep 14, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: optimize the store state filter metrics rleungx/pd
1 participant
@rleungx