Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestTwiceSplitKeyspaceGroup is unstable #6640

Closed
lhy1024 opened this issue Jun 20, 2023 · 5 comments
Closed

TestTwiceSplitKeyspaceGroup is unstable #6640

lhy1024 opened this issue Jun 20, 2023 · 5 comments
Labels
type/ci The issue is related to CI.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Jun 20, 2023 •
edited
Loading

Flaky Test

Which jobs are failing

TestTwiceSplitKeyspaceGroup

CI link

https://github.com/tikv/pd/actions/runs/5318613749/jobs/9630253535?pr=6639

Reason for failure (if possible)

2023-06-20T05:04:04.1781360Z --- FAIL: TestTwiceSplitKeyspaceGroup (28.59s)
2023-06-20T05:04:04.1781555Z     testutil.go:63: 
2023-06-20T05:04:04.1781981Z         	Error Trace:	/home/runner/work/pd/pd/pkg/utils/testutil/testutil.go:63
2023-06-20T05:04:04.1782863Z         	            				/home/runner/work/pd/pd/tests/integrations/mcs/tso/keyspace_group_manager_test.go:551
2023-06-20T05:04:04.1783132Z         	Error:      	Condition never satisfied
2023-06-20T05:04:04.1783430Z         	Test:       	TestTwiceSplitKeyspaceGroup

Anything else

It will block in

pd/pkg/tso/keyspace_group_manager.go

Lines 840 to 848 in 58d9208

if tsoutil.CompareTimestamp(&splitSourceTSO, &splitTSO) <= 0 {
log.Debug("the split source TSO is not greater than the newly split TSO",
zap.Int64("split-source-tso-physical", splitSourceTSO.Physical),
zap.Int64("split-source-tso-logical", splitSourceTSO.Logical),
zap.Int64("split-tso-physical", splitTSO.Physical),
zap.Int64("split-tso-logical", splitTSO.Logical),
)
return nil
}

Maybe we need to use reset ts again.
@lhy1024 lhy1024 added the type/ci The issue is related to CI. label Jun 20, 2023
@binshi-bing
Copy link
Contributor

binshi-bing commented Jun 20, 2023 •
edited by rleungx
Loading

it seems to be client exited shorted after started.

[2023/06/20 04:57:12.059 +00:00] [WARN] [pd_service_discovery.go:436] ["[pd] failed to get cluster id"] [url=http://127.0.0.1:40941]/ [error="[PD:client:ErrClientGetMember]error:type:UNKNOWN message:\"[PD:server:ErrServerNotStarted]server not started\"  target:127.0.0.1:40941 status:READY: error:type:UNKNOWN message:\"[PD:server:ErrServerNotStarted]server not started\"  target:127.0.0.1:40941 status:READY"]
[2023/06/20 04:57:12.060 +00:00] [WARN] [pd_service_discovery.go:436] ["[pd] failed to get cluster id"] [url=http://127.0.0.1:40941]/ [error="[PD:client:ErrClientGetMember]error:type:UNKNOWN message:\"[PD:server:ErrServerNotStarted]server not started\"  target:127.0.0.1:40941 status:READY: error:type:UNKNOWN message:\"[PD:server:ErrServerNotStarted]server not started\"  target:127.0.0.1:40941 status:READY"]
[2023/06/20 04:57:12.064 +00:00] [INFO] [server.go:409] ["init cluster id"] [cluster-id=7246627873164592125]
[2023/06/20 04:57:12.064 +00:00] [INFO] [member.go:333] ["member joining election"] [member-info="name:\"pd1\" member_id:13840790301888742108 peer_urls:\"[http://127.0.0.1:38501\](http://127.0.0.1:38501/)" client_urls:\"[http://127.0.0.1:40941\](http://127.0.0.1:40941/)" "] [root-path=/pd/7246627873164592125]
[2023/06/20 04:57:13.071 +00:00] [INFO] [tso_service_discovery.go:494] ["[tso] updated keyspace group service discovery info"] [keyspace-group-service="user_kind:\"basic\" members:<address:\"[http://127.0.0.1:35857\](http://127.0.0.1:35857/)" is_primary:true > members:<address:\"[http://127.0.0.1:43853\](http://127.0.0.1:43853/)" > "]
[2023/06/20 04:57:13.072 +00:00] [INFO] [client.go:595] ["[pd] changing service mode"] [old-mode=UNKNOWN_SVC_MODE] [new-mode=API_SVC_MODE]
[2023/06/20 04:57:13.072 +00:00] [INFO] [tso_service_discovery.go:184] ["created tso service discovery"] [cluster-id=7246627873164592125] [keyspace-id=0] [default-discovery-key=/ms/7246627873164592125/tso/00000/primary]
[2023/06/20 04:57:13.072 +00:00] [INFO] [tso_service_discovery.go:194] ["initializing tso service discovery"] [max-retry-times=100] [retry-interval=1s]
[2023/06/20 04:57:13.072 +00:00] [INFO] [tso_client.go:230] ["[tso] switch dc tso allocator serving address"] [dc-location=global] [new-address=http://127.0.0.1:35857]
[2023/06/20 04:57:13.072 +00:00] [INFO] [tso_service_discovery.go:412] ["[tso] switch primary"] [new-primary=http://127.0.0.1:35857] [old-primary=]
[2023/06/20 04:57:13.072 +00:00] [INFO] [tso_service_discovery.go:583] ["update tso server addresses"] [addrs="[http://127.0.0.1:35857,http://127.0.0.1:43853]"]
[2023/06/20 04:57:13.075 +00:00] [INFO] [tso_service_discovery.go:494] ["[tso] updated keyspace group service discovery info"] [keyspace-group-service="user_kind:\"basic\" members:<address:\"http://127.0.0.1:35857\" is_primary:true > members:<address:\"http://127.0.0.1:43853\" > "]
[2023/06/20 04:57:13.077 +00:00] [INFO] [tso_client.go:230] ["[tso] switch dc tso allocator serving address"] [dc-location=global] [new-address=http://127.0.0.1:35857]
[2023/06/20 04:57:13.077 +00:00] [INFO] [tso_service_discovery.go:412] ["[tso] switch primary"] [new-primary=http://127.0.0.1:35857] [old-primary=]
[2023/06/20 04:57:13.078 +00:00] [INFO] [tso_dispatcher.go:291] ["[tso] tso dispatcher created"] [dc-location=global]
[2023/06/20 04:57:13.078 +00:00] [INFO] [client.go:643] ["[pd] service mode changed"] [old-mode=UNKNOWN_SVC_MODE] [new-mode=API_SVC_MODE]
[2023/06/20 04:57:13.084 +00:00] [INFO] [tso_dispatcher.go:291] ["[tso] tso dispatcher created"] [dc-location=global]
[2023/06/20 04:57:13.084 +00:00] [INFO] [client.go:643] ["[pd] service mode changed"] [old-mode=UNKNOWN_SVC_MODE] [new-mode=API_SVC_MODE]
[2023/06/20 04:57:13.087 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:41195  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:41195: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.090 +00:00] [INFO] [client.go:522] ["[pd] create pd client with endpoints and keyspace"] [pd-address="[http://127.0.0.1:40941]"] [keyspace-name=keyspace_b] [keyspace-id=2]
[2023/06/20 04:57:13.091 +00:00] [INFO] [client.go:522] ["[pd] create pd client with endpoints and keyspace"] [pd-address="[http://127.0.0.1:40941]"] [keyspace-name=keyspace_a] [keyspace-id=1]
[2023/06/20 04:57:13.095 +00:00] [INFO] [server.go:1178] ["PD server config is updated"] [new="{\"use-region-storage\":\"true\",\"max-gap-reset-ts\":\"24h0m0s\",\"key-type\":\"table\",\"runtime-services\":\"\",\"metric-storage\":\"\",\"dashboard-address\":\"http://127.0.0.1:40941\",\"trace-region-flow\":\"true\",\"flow-round-by-digit\":3,\"min-resolved-ts-persistence-interval\":\"1s\",\"server-memory-limit\":0,\"server-memory-limit-gc-trigger\":0.7,\"enable-gogc-tuner\":\"false\",\"gc-tuner-threshold\":0.6}"] [old="{\"use-region-storage\":\"true\",\"max-gap-reset-ts\":\"24h0m0s\",\"key-type\":\"table\",\"runtime-services\":\"\",\"metric-storage\":\"\",\"dashboard-address\":\"auto\",\"trace-region-flow\":\"true\",\"flow-round-by-digit\":3,\"min-resolved-ts-persistence-interval\":\"1s\",\"server-memory-limit\":0,\"server-memory-limit-gc-trigger\":0.7,\"enable-gogc-tuner\":\"false\",\"gc-tuner-threshold\":0.6}"]
[2023/06/20 04:57:13.096 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.115 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.117 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.124 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:41195  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:41195: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.142 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:46527  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:46527: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.144 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.181 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:41195  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:41195: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.194 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.206 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:46527  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:46527: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.241 +00:00] [INFO] [keyspace_group_manager.go:560] ["the keyspace group's keyspace list is changed"] [keyspace-group-id=0] [old-keyspaces-count=3] [new-keyspaces-count=2]
[2023/06/20 04:57:13.241 +00:00] [INFO] [keyspace_group_manager.go:429] ["joining primary election"] [keyspace-group-id=1] [participant-name=http://127.0.0.1:35857-00001] [participant-id=16502472309315124447]
[2023/06/20 04:57:13.242 +00:00] [INFO] [participant.go:84] ["participant joining election"] [participant-info="name:\"http://127.0.0.1:35857-00001\" id:16502472309315124447 listen_urls:\"http://127.0.0.1:35857\" "] [leader-path=/ms/7246627873164592125/tso/keyspace_groups/election/00001/primary]
[2023/06/20 04:57:13.242 +00:00] [INFO] [keyspace_group_manager.go:443] ["keyspace group is in split"] [target=1] [source=0]
[2023/06/20 04:57:13.242 +00:00] [INFO] [allocator_manager.go:727] ["entering into allocator daemon"] [keyspace-group-id=1]
[2023/06/20 04:57:13.242 +00:00] [INFO] [keyspace_group_manager.go:470] ["created allocator manager"] [keyspace-group-id=1] [timestamp-path=/ms/7246627873164592125/tso/00001/gta/timestamp]
[2023/06/20 04:57:13.243 +00:00] [INFO] [keyspace_group_manager.go:560] ["the keyspace group's keyspace list is changed"] [keyspace-group-id=0] [old-keyspaces-count=3] [new-keyspaces-count=2]
[2023/06/20 04:57:13.244 +00:00] [INFO] [keyspace_group_manager.go:429] ["joining primary election"] [keyspace-group-id=1] [participant-name=http://127.0.0.1:43853-00001] [participant-id=15518490588729840121]
[2023/06/20 04:57:13.244 +00:00] [INFO] [participant.go:84] ["participant joining election"] [participant-info="name:\"http://127.0.0.1:43853-00001\" id:15518490588729840121 listen_urls:\"http://127.0.0.1:43853\" "] [leader-path=/ms/7246627873164592125/tso/keyspace_groups/election/00001/primary]
[2023/06/20 04:57:13.244 +00:00] [INFO] [keyspace_group_manager.go:443] ["keyspace group is in split"] [target=1] [source=0]
[2023/06/20 04:57:13.245 +00:00] [INFO] [global_allocator.go:562] ["start to campaign the primary"] [keyspace-group-id=1] [campaign-tso-primary-name=http://127.0.0.1:35857-00001]
[2023/06/20 04:57:13.245 +00:00] [INFO] [allocator_manager.go:727] ["entering into allocator daemon"] [keyspace-group-id=1]
[2023/06/20 04:57:13.245 +00:00] [INFO] [keyspace_group_manager.go:470] ["created allocator manager"] [keyspace-group-id=1] [timestamp-path=/ms/7246627873164592125/tso/00001/gta/timestamp]
[2023/06/20 04:57:13.246 +00:00] [INFO] [global_allocator.go:562] ["start to campaign the primary"] [keyspace-group-id=1] [campaign-tso-primary-name=http://127.0.0.1:43853-00001]
[2023/06/20 04:57:13.247 +00:00] [INFO] [global_allocator.go:571] ["campaign tso primary meets error due to pre-check campaign failed, the tso keyspace group may be in split"] [keyspace-group-id=1] [campaign-tso-primary-name=http://127.0.0.1:43853-00001]
[2023/06/20 04:57:13.248 +00:00] [INFO] [lease.go:66] ["lease granted"] [lease-id=206[1901](https://github.com/tikv/pd/actions/runs/5318613749/jobs/9630253535?pr=6639#step:5:1902)40655309917] [lease-timeout=3] [purpose="keyspace group primary election"]
[2023/06/20 04:57:13.249 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.250 +00:00] [INFO] [leadership.go:124] ["check campaign resp"] [resp="{\"header\":{\"cluster_id\":11772235485245353159,\"member_id\":13840790301888742108,\"revision\":30,\"raft_term\":2},\"succeeded\":true,\"responses\":[{\"Response\":{\"ResponsePut\":{\"header\":{\"revision\":30}}}}]}"]
[2023/06/20 04:57:13.251 +00:00] [INFO] [global_allocator.go:547] ["start to watch the primary"] [keyspace-group-id=1] [campaign-tso-primary-name=http://127.0.0.1:43853-00001] [tso-primary="name:\"http://127.0.0.1:35857/-00001\" id:16502472309315124447 listen_urls:\"[http://127.0.0.1:35857\](http://127.0.0.1:35857/)" "]
[2023/06/20 04:57:13.250 +00:00] [INFO] [leadership.go:133] ["write leaderData to leaderPath ok"] [leaderPath=/ms/7246627873164592125/tso/keyspace_groups/election/00001/primary] [purpose="keyspace group primary election"]
[2023/06/20 04:57:13.251 +00:00] [INFO] [global_allocator.go:595] ["campaign tso primary ok"] [keyspace-group-id=1] [campaign-tso-primary-name=http://127.0.0.1:35857-00001]
[2023/06/20 04:57:13.251 +00:00] [INFO] [lease.go:143] ["start lease keep alive worker"] [interval=1s] [purpose="keyspace group primary election"]
[2023/06/20 04:57:13.251 +00:00] [INFO] [global_allocator.go:606] ["initializing the global tso allocator"]
[2023/06/20 04:57:13.256 +00:00] [INFO] [tso.go:185] ["sync and save timestamp"] [last=0001/01/01 00:00:00.000 +00:00] [save=2023/06/20 04:57:16.253 +00:00] [next=2023/06/20 04:57:13.253 +00:00]
[2023/06/20 04:57:13.256 +00:00] [INFO] [global_allocator.go:625] ["tso primary is ready to serve"] [keyspace-group-id=1] [tso-primary-name=http://127.0.0.1:35857-00001]
[2023/06/20 04:57:13.262 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:36909  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:36909: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.324 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:46527  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:46527: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.334 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:41195  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:41195: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.379 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:41195  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:41195: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.399 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:41195  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:41195: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.415 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:46527  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:46527: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.422 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:46527  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:46527: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.828 +00:00] [WARN] [grpclog.go:60] ["grpc: addrConn.createTransport failed to connect to {127.0.0.1:34717  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:34717: connect: connection refused\". Reconnecting..."]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_service_discovery.go:253] ["[tso] exit check member loop"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_dispatcher.go:376] ["[tso] stop fetching the pending tso requests due to context canceled"] [dc-location=global]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_dispatcher.go:312] ["[tso] exit tso dispatcher"] [dc-location=global]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_dispatcher.go:215] ["exit tso dispatcher loop"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_dispatcher.go:163] ["exit tso requests cancel loop"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_service_discovery.go:226] ["closing tso service discovery"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_service_discovery.go:239] ["tso service discovery is closed"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_client.go:134] ["closing tso client"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_client.go:139] ["close tso client"]
[2023/06/20 04:57:13.954 +00:00] [INFO] [tso_client.go:150] ["tso client is closed"]
[2023/06/20 04:57:13.955 +00:00] [INFO] [pd_service_discovery.go:278] ["[pd] close pd service discovery client"]
[2023/06/20 04:57:14.059 +00:00] [INFO] [keyspace_group_manager.go:560] ["the keyspace group's keyspace list is changed"] [keyspace-group-id=0] [old-keyspaces-count=2] [new-keyspaces-count=1]
[2023/06/20 04:57:14.060 +00:00] [INFO] [keyspace_group_manager.go:429] ["joining primary election"] [keyspace-group-id=2] [participant-name=http://127.0.0.1:43853-00002] [participant-id=7828928727038704858]
[2023/06/20 04:57:14.060 +00:00] [INFO] [participant.go:84] ["participant joining election"] [participant-info="name:\"http://127.0.0.1:43853-00002\" id:7828928727038704858 listen_urls:\"[http://127.0.0.1:43853\](http://127.0.0.1:43853/)" "] [leader-path=/ms/7246627873164592125/tso/keyspace_groups/election/00002/primary]
[2023/06/20 04:57:14.060 +00:00] [INFO] [keyspace_group_manager.go:443] ["keyspace group is in split"] [target=2] [source=0]
[2023/06/20 04:57:14.060 +00:00] [INFO] [allocator_manager.go:727] ["entering into allocator daemon"] [keyspace-group-id=2]
[2023/06/20 04:57:14.060 +00:00] [INFO] [keyspace_group_manager.go:470] ["created allocator manager"] [keyspace-group-id=2] [timestamp-path=/ms/7246627873164592125/tso/00002/gta/timestamp]
[2023/06/20 04:57:14.061 +00:00] [INFO] [keyspace_group_manager.go:560] ["the keyspace group's keyspace list is changed"] [keyspace-group-id=0] [old-keyspaces-count=2] [new-keyspaces-count=1]
[2023/06/20 04:57:14.061 +00:00] [INFO] [keyspace_group_manager.go:429] ["joining primary election"] [keyspace-group-id=2] [participant-name=http://127.0.0.1:35857-00002] [participant-id=6514483358733294836]
[2023/06/20 04:57:14.061 +00:00] [INFO] [participant.go:84] ["participant joining election"] [participant-info="name:\"http://127.0.0.1:35857-00002\" id:6514483358733294836 listen_urls:\"[http://127.0.0.1:35857\](http://127.0.0.1:35857/)" "] [leader-path=/ms/7246627873164592125/tso/keyspace_groups/election/00002/primary]

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 20, 2023

https://github.com/tikv/pd/actions/runs/5319664898/jobs/9632425861 a new ci link

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 21, 2023

it is closed by #6652

@lhy1024 lhy1024 closed this as completed Jun 21, 2023
@rleungx
Copy link
Member

rleungx commented Jun 21, 2023 •
edited
Loading

Can you explain more about the case and why it is related to #6652?

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jun 21, 2023 •
edited
Loading

Can you explain more about the case and why it is related to #6652?

As pr describe, it will block in

pd/pkg/tso/keyspace_group_manager.go

Lines 840 to 848 in 58d9208

if tsoutil.CompareTimestamp(&splitSourceTSO, &splitTSO) <= 0 {
log.Debug("the split source TSO is not greater than the newly split TSO",
zap.Int64("split-source-tso-physical", splitSourceTSO.Physical),
zap.Int64("split-source-tso-logical", splitSourceTSO.Logical),
zap.Int64("split-tso-physical", splitTSO.Physical),
zap.Int64("split-tso-logical", splitTSO.Logical),
)
return nil
}
, return nil directly, so cannot finish split

After #6652, it returns kgm.finishSplitKeyspaceGroup(keyspaceGroupID), so this block is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/ci The issue is related to CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lhy1024 @rleungx @binshi-bing