Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key boundaries in compaction filter context #318

Closed
wants to merge 2 commits into from

Conversation

zgcbj
Copy link

@zgcbj zgcbj commented Sep 29, 2022

Fix #317

@zgcbj zgcbj changed the title fix Remove ExtractUserKey of start、end in CreateCompactionFilter fix #317 Remove ExtractUserKey of start、end in CreateCompactionFilter Sep 29, 2022
Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO and Format is failing.

@tabokie tabokie requested a review from Connor1996 September 29, 2022 04:44
@zgcbj zgcbj force-pushed the 6.29.tikv branch 2 times, most recently from 44a0a40 to 5490978 Compare September 29, 2022 06:09
Signed-off-by: zhangguangchao <1614439+zgcbj@users.noreply.github.com>
@zgcbj zgcbj requested review from tabokie and removed request for Connor1996 September 29, 2022 06:59
@tabokie tabokie changed the title fix #317 Remove ExtractUserKey of start、end in CreateCompactionFilter fix key boundaries in compaction filter context Oct 8, 2022
@tabokie tabokie requested review from hicqu and Connor1996 October 8, 2022 07:17
@tabokie
Copy link
Member

tabokie commented Oct 8, 2022

/run-test

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to cover it

@zgcbj zgcbj force-pushed the 6.29.tikv branch 2 times, most recently from 4bd84b8 to 7ecedd9 Compare October 18, 2022 07:57
Signed-off-by: zhangguangchao <1614439+zgcbj@users.noreply.github.com>
@zgcbj
Copy link
Author

zgcbj commented Oct 18, 2022

I want test these code use subcompaction with compactionfilterfactory, but it failed at generate data. I can`t fix it. Please help me figure it out.

@zgcbj zgcbj closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I think start is userkey here!
3 participants