Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel commit testing plan #23

Open
nrc opened this issue Jun 23, 2020 · 9 comments
Open

Parallel commit testing plan #23

nrc opened this issue Jun 23, 2020 · 9 comments
Labels
T-async-commit Topic: async commit

Comments

@nrc
Copy link
Collaborator

nrc commented Jun 23, 2020

Beyond simple unit tests, we should have a plan to test parallel commit thoroughly. Some ideas:

  • Running our various test suites in CI with parallel commit enabled.
  • Benchmarking to ensure performance
  • Adding parallel commit to our TLA+ model

More ideas (and elaborating on the above) welcome!

@nrc nrc added the T-async-commit Topic: async commit label Jun 23, 2020
@youjiali1995
Copy link
Contributor

I will introduce it to QA team and they will design the test plan for it.

@cfzjywxk
Copy link
Contributor

@nrc @MyonKeminta
Do we need to list specific development tasks in issues? We could learn which task is assigned or available, and we could track the progress. Some tasks with high priorities could be labeled and we could make it run if they are done.

@nrc
Copy link
Collaborator Author

nrc commented Jun 30, 2020

Do we need to list specific development tasks in issues

Do you mean for the test plan, or more generally?

There is tikv/tikv#8126, tikv/tikv#8127, tikv/tikv#8128 for the latter, which gets us to the end of the first iteration. I haven't filed TiDB issues for that side, but have some notes locally.

@youjiali1995
Copy link
Contributor

I will introduce it to @zyguan next week.

@cfzjywxk
Copy link
Contributor

@cfzjywxk
Copy link
Contributor

I will introduce it to @zyguan next week.

Yes, this feature is more complex, we need to get @zyguan involved and start to design tests earlier

@zyguan
Copy link

zyguan commented Jul 8, 2020

Sorry for the late reply, I'm working on it.

@nrc
Copy link
Collaborator Author

nrc commented Jul 9, 2020

Sorry for the late reply, I'm working on it.

No problem! Is there anywhere we can track work? Is there anything we can help with?

@nrc
Copy link
Collaborator Author

nrc commented Jul 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-async-commit Topic: async commit
Projects
None yet
Development

No branches or pull requests

4 participants