Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In what ember-source version do I no longer need this addon? #86

Closed
NullVoxPopuli opened this issue Jul 12, 2022 · 3 comments
Closed

In what ember-source version do I no longer need this addon? #86

NullVoxPopuli opened this issue Jul 12, 2022 · 3 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

I forget if this has been implemented yet

@chancancode
Copy link
Member

From the README

This addon provides a polyfill high fidelity reference implementation of
RFC #389, including the proposed
amendments in RFC PR #620.

Please note that while RFC #389
has been approved, it has not been implemented in Ember.js yet. As such, the
feature is still subject to change based on implementation feedback.

When this feature is implemented in Ember.js, we will release a 1.0 version of
this addon as a true polyfill for the feature, allowing the feature to be used
on older Ember.js versions and be completely inert on newer versions where the
official implementation is available.

I believe this is still current.

@NullVoxPopuli
Copy link
Collaborator Author

how do we implement the element helper? would that be a glimmer-vm thing?

@chancancode
Copy link
Member

Yeah. I think so. We will probably have to invent some new concepts in the glimmer-vm internals to thread this through. I suppose we can also try to reuse the existing code that handles the classic ember components since apparently that works almost perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants