Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg-config protobuf --version needs to be pkg-config protobuf --nodversion #2715

Open
dreirund opened this issue May 15, 2019 · 1 comment
Open
Assignees
Labels

Comments

@dreirund
Copy link

Describe the bug
./configure.js spills out

[...]
[tilemill configure] Could not configure TileMill because "pkg-config protobuf --version" returned an error (pkgconf: --version specified with other options or module names, assuming --modversion.)

This does come from a run of pkg-config protobuf --version:

pkgconf: --version specified with other options or module names, assuming --modversion.
3.7.0

Instead, pkg-config protobuf --modversion should be executed:

3.7.0

Environment: (Note: We are not setup to test on Linux or Windows so help may be slower on those OSs)

  • OS & Version: Arch/ Artix Linux
  • Node Version [e.g. v8.15.0] node --version: v11.15.0

To Reproduce

  • git clone git://github.com/tilemill-project/tilemill.git
  • cd tilemill
  • ./configure.js

Expected behavior
./configure.js finishes without error messages.

@dreirund dreirund added the bug label May 15, 2019
@dreirund
Copy link
Author

Patch attached.

AND: Please configure your issue tracker to support .patch and .diff-files as well. You make it unneededly complicated for users to hand in patches ... (who does not use git but uses the "classic" ways ...)

configure-js.protobuf.fix-versionargument.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants