Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roads layer min_zooms at zoom 5 are mix of 3, 4 and 5 instead of just 5.x #1074

Closed
nvkelso opened this issue Sep 22, 2016 · 3 comments
Closed
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 22, 2016

tl;dr

We only query NE data starting at zoom 5, but the roads min_zoom also includes z3 and z4 values.

Let's do what we did for NE water labels (#1812) and clamp the exported min_zoom to the tile's min_zoom.

We should set:

  • 3 to 5.0
  • 4 to 5.1
  • 5 to 5.2

===

This may be happening in more layers than roads...

  • What did you see? Roads receive min_zoom values of 3 and 4 at zoom 5, but are only included in tiles starting at zoom 5.
  • What did you expect to see? Either include the roads earlier, or cap the min_zoom of the roads at layer's start_zoom of 5.
  • What map location are you having problems with? 5/41.162/-100.195
  • Screenshot?

screen shot 2016-09-21 at 23 15 35

screen shot 2016-09-21 at 23 15 21

@nvkelso nvkelso added this to the v1.1.0 milestone Sep 22, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Sep 22, 2016

Boundaries sees this to an extent on the transition from NE 1:50m data to 1:10m data at zoom 5 when countries like Russia suddenly pop in.

@nvkelso
Copy link
Member Author

nvkelso commented Oct 5, 2016

This also happens for national_park features in pois layer.

@nvkelso nvkelso modified the milestones: v1.2.0, v1.1.0 Dec 28, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Jun 27, 2017

/cc @sensescape This bug explains the lack of Natural Earth roads in zoom 3, 4 tiles!

@nvkelso nvkelso modified the milestones: v1.6.0, v1.7.0 Nov 5, 2018
@nvkelso nvkelso modified the milestones: v1.8.0, v1.7.0 Jan 8, 2019
@nvkelso nvkelso added the query label Feb 13, 2019
@nvkelso nvkelso changed the title feature min_zoom should align with layer query min_zoom roads layer min_zooms at zoom 5 are mix of 3, 4 and 5 instead of just 5 Feb 13, 2019
@nvkelso nvkelso changed the title roads layer min_zooms at zoom 5 are mix of 3, 4 and 5 instead of just 5 roads layer min_zooms at zoom 5 are mix of 3, 4 and 5 instead of just 5.x Feb 13, 2019
@nvkelso nvkelso modified the milestones: v1.9.0, v1.8.0 Feb 20, 2019
@nvkelso nvkelso self-assigned this May 1, 2019
@nvkelso nvkelso closed this as completed in 7d1f78a May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant