Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove natural_forest and natural_wood from pois layer #1103

Closed
nvkelso opened this issue Oct 5, 2016 · 4 comments
Closed

Remove natural_forest and natural_wood from pois layer #1103

nvkelso opened this issue Oct 5, 2016 · 4 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Oct 5, 2016

These should only be label placements in the landuse layer but are now appearing in the pois layer.

  # natural forests - note already clamped to z12
  - filter: {natural: forest}
    min_zoom: { min: [ { max: [ 12, { lit: zoom + 2 }, { lit: *tier2_min_zoom } ] }, 14 ] }
    output: { kind: natural_forest, tier: 2 }

  # natural woods - note already clampted to 12
  - filter: {natural: wood}
    min_zoom: { min: [ { max: [ 12, { lit: zoom + 2 }, { lit: *tier2_min_zoom } ] }, 14 ] }
    output: { kind: natural_wood, tier: 2 }

Example:

{
type: "Point",
properties: {
kind: "natural_wood",
area: 2426,
source: "openstreetmap.org",
min_zoom: 14,
tier: 2,
id: -1756198,
osm_relation: true
},
coordinates: [
388,
933
]
},

screen shot 2016-10-04 at 22 08 40

Curious that we're even showing those without any names!

@nvkelso nvkelso added the bug label Oct 5, 2016
@nvkelso nvkelso added this to the v1.1.0 milestone Oct 5, 2016
@nvkelso
Copy link
Member Author

nvkelso commented Oct 5, 2016

Possibly also village_green?

screen shot 2016-10-04 at 22 41 54

@nvkelso
Copy link
Member Author

nvkelso commented Apr 19, 2017

I can find the 2nd example for Mt. Cydonia Ponds Natural Area label position but not the 3rd example in this test for Liebesinsel. Both were fresh generated tiles.

@zerebubuth
Copy link
Member

I think this might have been because tileserver and tilequeue were using different date prefixes - I forgot to update the tileserver one after the dev build finished. It's looking okay for me now. Could you check that it's looking good for you too, please?

@nvkelso
Copy link
Member Author

nvkelso commented Apr 20, 2017

Verified :)

@nvkelso nvkelso closed this as completed Apr 20, 2017
@ghost ghost removed the send to staging label Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants