Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer local network versus E-road network in shield creation #1483

Closed
nvkelso opened this issue Apr 4, 2018 · 3 comments
Closed

Prefer local network versus E-road network in shield creation #1483

nvkelso opened this issue Apr 4, 2018 · 3 comments
Assignees
Milestone

Comments

@nvkelso
Copy link
Member

nvkelso commented Apr 4, 2018

  • What did you see? E-roads are useful, but usually as auxiliary to the local A-road, M-road & etc tagging.
  • What did you expect to see? See the local A-road first as default network and shield_text values. The e-road should only be included in the extra list of networks and shield_texts (which are included in GeoJSON and TopoJSON but not in MVT which is tangential but important as Tangram doesn't support multi-shields at this time).
  • What map location are you having problems with? Europe. Rome, Milan, Amsterdam, etc.
  • Screenshot?

http://localhost:8000/#11/41.8293/372.6037
In this case A90 is expected instead of E80.

screen shot 2018-04-04 at 4 51 47 pm

@nvkelso
Copy link
Member Author

nvkelso commented Apr 11, 2018

For low zooms from Natural Earth we'll probably also need to prefer the local (A*, N*, etc) value instead of the label (E-road) value for default shields.

@zerebubuth
Copy link
Member

It looks like this should be possible by tweaking the network importance by assigning a high value (higher means less important) to network_code when it's an "E-road". See also a previous comment, which makes me think we might need to do this on a region-by-region basis, depending on what the local visibility of these names is (i.e: US interstates are the equivalent of EU "e-roads" in network hierarchy, but interstates are much more prominently signed).

@nvkelso
Copy link
Member Author

nvkelso commented Apr 27, 2018

Good low hanging fruit 🥝 🍌 🍒 🍓 🍏

@nvkelso nvkelso self-assigned this Apr 28, 2018
@nvkelso nvkelso mentioned this issue Apr 28, 2018
3 tasks
@ghost ghost added the in review label Apr 28, 2018
@ghost ghost removed the in review label Apr 30, 2018
@nvkelso nvkelso added this to the v1.5.0 milestone Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants