Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip names off most boundary lines at low and mid-zooms #1683

Closed
nvkelso opened this issue Sep 29, 2018 · 3 comments
Closed

Strip names off most boundary lines at low and mid-zooms #1683

nvkelso opened this issue Sep 29, 2018 · 3 comments

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 29, 2018

We include default and localized name:left and name:right properties on boundary lines when the aren't used for labeling until later zooms. This bloats file size.

There are also hints in Natural Earth about the zoom they should start being labeled we can leverage.

@nvkelso nvkelso added this to the v1.6.0 milestone Sep 29, 2018
@nvkelso
Copy link
Member Author

nvkelso commented Oct 26, 2018

SEO: boundaries layer

We could also follow the lead in #1693 and drop features and names (name and name:*) based on the NE min_zoom and min_label?

@nvkelso
Copy link
Member Author

nvkelso commented Dec 14, 2018

Looking around Switzerland I still see a lot of name variants that aren't labeled but there in the data, but overall this is working (as proved by the reduction in the boundary layer size) so I think it's just a parameter tuning opportunity in the next release, with possible incorporation of the Natural Earth zooms as it's not necessary to include both the label centroid and the line names at most zooms together.

8/47.132/8.432

image

Like:

image

@nvkelso
Copy link
Member Author

nvkelso commented Dec 14, 2018

This is mostly working, closing.

@nvkelso nvkelso closed this as completed Dec 14, 2018
@ghost ghost removed the in review label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants